Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a kubelet serving cert age metric #84534

Merged
merged 2 commits into from Nov 4, 2019

Conversation

@sambdavidson
Copy link
Contributor

sambdavidson commented Oct 29, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:
Adds a histogram metric for kubelet serving cert rotation ages managed by client-go's certificate Manager. This metric will provide insights into the average age of serving certificates before they are rotated.

Special notes for your reviewer:
Serving certificate version of the same metric from pull/84382.

Does this PR introduce a user-facing change?:

Added kubelet serving certificate metric `server_rotation_seconds` which is a histogram reporting the age of a just rotated serving certificate in seconds.

/assign @awly @logicalhan
/cc @mikedanese @liggitt @dashpole

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 29, 2019

Hi @sambdavidson. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikedanese mikedanese changed the title Server rot metric add a kubelet serving cert age metric Oct 29, 2019
@awly

This comment has been minimized.

Copy link
Contributor

awly commented Oct 29, 2019

/ok-to-test

@sambdavidson sambdavidson changed the title add a kubelet serving cert age metric Add a kubelet serving cert age metric Oct 29, 2019
@sambdavidson sambdavidson force-pushed the sambdavidson:serverRotMetric branch from 765a27a to c269135 Oct 29, 2019
@awly

This comment has been minimized.

Copy link
Contributor

awly commented Oct 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 29, 2019
Copy link
Contributor

mattjmcnaughton left a comment

Thanks for your work here @sambdavidson!

A couple questions and one small nit from me :)

@sambdavidson sambdavidson force-pushed the sambdavidson:serverRotMetric branch from c269135 to 4138224 Oct 30, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 30, 2019
@sambdavidson

This comment has been minimized.

Copy link
Contributor Author

sambdavidson commented Oct 31, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

Copy link
Contributor

mattjmcnaughton left a comment

Thanks for addressing my comments!

Will let an approver give the final sign-off and approval :)
/assign @mikedanese

@sambdavidson sambdavidson force-pushed the sambdavidson:serverRotMetric branch from 4138224 to bc92565 Oct 31, 2019
certificateRotationAge := compbasemetrics.NewHistogram(
&compbasemetrics.HistogramOpts{
Namespace: metrics.KubeletSubsystem,
Subsystem: "certificate_manager",

This comment has been minimized.

Copy link
@mikedanese

mikedanese Oct 31, 2019

Member

Why are you puting KubeletSubystem in namespace and not subsystem?

This comment has been minimized.

Copy link
@sambdavidson

sambdavidson Nov 1, 2019

Author Contributor

The strings Namespace, Subsystem, and Name are just concatenated.

See the function.

So it doesn't actually matter whether its a namespace or system, all that matters is that they are in the same order. I changed it to be less confusing but functionally the same.

@sambdavidson sambdavidson force-pushed the sambdavidson:serverRotMetric branch from bc92565 to 3e817d1 Nov 1, 2019
@mikedanese

This comment has been minimized.

Copy link
Member

mikedanese commented Nov 1, 2019

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 1, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, sambdavidson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips

This comment has been minimized.

Copy link
Member

rphillips commented Nov 4, 2019

/kind feature
/high-priority

@k8s-ci-robot k8s-ci-robot added kind/feature and removed needs-kind labels Nov 4, 2019
@rphillips

This comment has been minimized.

Copy link
Member

rphillips commented Nov 4, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot merged commit 0ed6635 into kubernetes:master Nov 4, 2019
15 checks passed
15 checks passed
cla/linuxfoundation sambdavidson authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 4, 2019
@coderanger

This comment has been minimized.

Copy link

coderanger commented Nov 5, 2019

/sig instrumentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.