Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure/azure-sdk-for-go #84543

Merged
merged 2 commits into from Oct 31, 2019
Merged

Conversation

@andyzhangx
Copy link
Member

andyzhangx commented Oct 30, 2019

What type of PR is this?
/kind cleanup
/kind feature

What this PR does / why we need it:
Update Azure modules:

  • github.com/Azure/azure-sdk-for-go v35.0.0+incompatible

Which issue(s) this PR fixes:

Fixes #84516

Special notes for your reviewer:

hack/pin-dependency.sh github.com/Azure/azure-sdk-for-go v35.0.0+incompatible
hack/update-vendor.sh

Does this PR introduce a user-facing change?:

Update Azure SDK versions to v35.0.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

/kind bug
/assign @feiskyer @justaugustus
/priority important-soon
/sig cloud-provider
/area provider/azure

@andyzhangx

This comment has been minimized.

Copy link
Member Author

andyzhangx commented Oct 30, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@andyzhangx

This comment has been minimized.

Copy link
Member Author

andyzhangx commented Oct 30, 2019

@chewong could you take a look at this failure? Thanks.

W1030 05:14:38.610] 2019/10/30 05:14:38 main.go:319: Something went wrong: starting e2e cluster: failed to generate ARM templates: failed to generate ARM templates: error during /go/src/k8s.io/kubernetes/aks-engine generate /workspace/aks648705628/kubernetes.json --output-directory /workspace/aks648705628: exit status 1.
@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 30, 2019
Copy link
Member

feiskyer left a comment

/lgtm

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Oct 30, 2019

@kubernetes/dep-approvers could you help to take a look?

@chewong

This comment has been minimized.

Copy link
Member

chewong commented Oct 30, 2019

@chewong could you take a look at this failure? Thanks.

W1030 05:14:38.610] 2019/10/30 05:14:38 main.go:319: Something went wrong: starting e2e cluster: failed to generate ARM templates: failed to generate ARM templates: error during /go/src/k8s.io/kubernetes/aks-engine generate /workspace/aks648705628/kubernetes.json --output-directory /workspace/aks648705628: exit status 1.

kubernetes/test-infra#14998 is currently affecting most of the Azure-related builds. I've already reverted the PR and waiting for @k8s-ci-robot to update the job configuration. Sorry about that.

@chewong

This comment has been minimized.

Copy link
Member

chewong commented Oct 30, 2019

/retest

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Oct 30, 2019

@kubernetes/dep-approvers could you help to take a look?

sure, still voicing my concern that we should be assigning one-two people from this list instead of CCing the entire list on any PR that changes dependencies though :|

cc @liggitt who will also inevitably have to approve anyhow, given dep-approvers cannot actually approve 🙄

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Oct 30, 2019

/approve

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Oct 30, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, BenTheElder, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4d55d1d into kubernetes:master Oct 31, 2019
16 checks passed
16 checks passed
cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 31, 2019
@craiglpeters craiglpeters added this to Done in Provider Azure Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.