Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate proxy env var to kube-proxy #84559

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@yastij
Copy link
Member

yastij commented Oct 30, 2019

Signed-off-by: Yassine TIJANI ytijani@vmware.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind feature
/priority backlog

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes kubernetes/kubeadm#1863

Special notes for your reviewer:

/assign @neolit123

Does this PR introduce a user-facing change?:

kubeadm now propagates proxy environment variables to kube-proxy

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


cmd/kubeadm/app/util/env.go Outdated Show resolved Hide resolved
@yastij yastij force-pushed the yastij:prox-env-kubeproxy branch from 32e8c1f to b484251 Oct 30, 2019
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
@yastij yastij force-pushed the yastij:prox-env-kubeproxy branch from b484251 to 3993c42 Oct 30, 2019
@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Oct 30, 2019

there is one pending question in the attached issue (i.e. why even use proxy* env vars for kube-proxy).
but i'm ok with the change.

/approve
/assign @ereslibre
PTAL for LGTM

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Oct 30, 2019

thanks for the fast PR @yastij

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented Oct 30, 2019

/retest

Copy link
Member

ereslibre left a comment

Thank you @yastij!

I am wondering whether we should leverage this to configuration, so the intent is clear, instead of implicit depending on runtime status.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit ef479c1 into kubernetes:master Oct 31, 2019
15 checks passed
15 checks passed
cla/linuxfoundation yastij authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.