Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GCE PD Access Mode reflect readonly status when translating an inline read only volume #84809

Merged
merged 1 commit into from Nov 6, 2019
Merged

Make GCE PD Access Mode reflect readonly status when translating an inline read only volume #84809

merged 1 commit into from Nov 6, 2019

Conversation

davidz627
Copy link
Contributor

/kind bug
/kind failing-test
/assign @ddebroy @misterikkit @msau42
/cc @jsafrane

Fixes #84736

CSI Migration: GCE PD access mode now reflects read only status of inline volumes - this allows multi-attach for read only many PDs

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 5, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 5, 2019
@davidz627
Copy link
Contributor Author

/priority important-soon
/sig storage

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@davidz627
Copy link
Contributor Author

/test pull-kubernetes-integration

msau42
msau42 reviewed Nov 5, 2019
View reviewed changes
staging/src/k8s.io/csi-translation-lib/plugins/gce_pd.go
pv := &v1.PersistentVolume{
var am v1.PersistentVolumeAccessMode
if pdSource.ReadOnly {
am = v1.ReadOnlyMany
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

today when an inline volume specifies readOnly, does that cause the attach to be readonly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, specifying readOnly: true inline causes the volume to be attached in mode: READ_ONLY

@msau42
Copy link
Member

msau42 commented Nov 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2019
@ddebroy
Copy link
Member

ddebroy commented Nov 6, 2019

/lgtm

k8s-ci-robot added a commit that referenced this pull request Nov 6, 2019
@k8s-ci-robot
Merge pull request #84809 from davidz627/fix/migReadOnly
41d9522 
Make GCE PD Access Mode reflect readonly status when translating an inline read only volume
@k8s-ci-robot k8s-ci-robot merged commit 41d9522 into kubernetes:master Nov 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 631e218 into kubernetes:master Nov 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 6, 2019
@davidz627 davidz627 deleted the fix/migReadOnly branch November 6, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@misterikkit misterikkit

@ddebroy ddebroy

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

Multi-attach scenarios for CSI-migrated-inline-volumes throw warnings and take a while
5 participants
@davidz627 @k8s-ci-robot @msau42 @ddebroy @misterikkit