Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving CSI Driver to GA. #84814

Merged
merged 4 commits into from Mar 6, 2020
Merged

Moving CSI Driver to GA. #84814

merged 4 commits into from Mar 6, 2020

Conversation

@huffmanca
Copy link
Contributor

huffmanca commented Nov 5, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Graduates the CSI Driver to GA. This only touches the API, their tests, and the associated staging files.

Which issue(s) this PR fixes:
Fixes kubernetes/enhancements#770

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The storage.k8s.io/CSIDriver has moved to GA, and is now available for use.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/pull/768
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 5, 2019

Hi @huffmanca. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from cheftako and dashpole Nov 5, 2019
@huffmanca huffmanca changed the title Moving CSI Driver and Node to GA. [wip] Moving CSI Driver and Node to GA. Nov 5, 2019
@huffmanca huffmanca changed the title [wip] Moving CSI Driver and Node to GA. [wip] Moving CSI Driver to GA. Nov 5, 2019
@huffmanca huffmanca force-pushed the huffmanca:ga_csi_driver branch from 8c85527 to 1f72f1c Nov 5, 2019
@huffmanca huffmanca changed the title [wip] Moving CSI Driver to GA. Moving CSI Driver to GA. Nov 5, 2019
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 5, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented Nov 5, 2019

/ok-to-test
/sig storage
/priority important-soon

Copy link
Contributor

smarterclayton left a comment

Some final things that need to be cleared up

@huffmanca huffmanca force-pushed the huffmanca:ga_csi_driver branch from 92551b8 to fb36d3a Mar 5, 2020
@huffmanca

This comment has been minimized.

Copy link
Contributor Author

huffmanca commented Mar 5, 2020

/test pull-kubernetes-e2e-kind

@huffmanca huffmanca force-pushed the huffmanca:ga_csi_driver branch from fb36d3a to a9f9010 Mar 5, 2020
@huffmanca

This comment has been minimized.

Copy link
Contributor Author

huffmanca commented Mar 5, 2020

@smarterclayton ,

After discussing this with @gnufied further, I've removed listType from the Items[] field and added a single API violation for this type.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Mar 5, 2020

/approve

API change is approved.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, jsafrane, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@huffmanca

This comment has been minimized.

Copy link
Contributor Author

huffmanca commented Mar 5, 2020

/test pull-kubernetes-e2e-kind

@gnufied gnufied force-pushed the huffmanca:ga_csi_driver branch from a9f9010 to 8970b2c Mar 6, 2020
@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Mar 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 6, 2020
@huffmanca

This comment has been minimized.

Copy link
Contributor Author

huffmanca commented Mar 6, 2020

/test pull-kubernetes-e2e-gce

@irvifa

This comment has been minimized.

Copy link
Member

irvifa commented Mar 6, 2020

@huffmanca I think you need to rebase this PR first.. There's a conflict on the csi_mounter

huffmanca and others added 4 commits Feb 28, 2020
Add a comment about GA feature
@huffmanca huffmanca force-pushed the huffmanca:ga_csi_driver branch from 8970b2c to d089053 Mar 6, 2020
@huffmanca

This comment has been minimized.

Copy link
Contributor Author

huffmanca commented Mar 6, 2020

/test pull-kubernetes-conformance-kind-ipv6-parallel

@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Mar 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 61847ea into kubernetes:master Mar 6, 2020
21 of 22 checks passed
21 of 22 checks passed
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation huffmanca authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ga-only-parallel Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6-parallel Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-snapshot Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.