Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #84693: Stop Watching when there is encoding error #84961

Conversation

@liggitt
Copy link
Member

liggitt commented Nov 8, 2019

Cherry pick of #84693 on release-1.15.

#84693: Stop Watching when there is encoding error

For details on the cherry pick process, see the cherry pick requests page.

kube-apiserver: fixed a bug that could cause a goroutine leak if the apiserver encountered an encoding error serving a watch to a websocket watcher
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Nov 8, 2019

/kind bug
/sig api-machinery

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Nov 8, 2019

/assign @lavalamp

@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Nov 8, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 8, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5c09ed7 into kubernetes:release-1.15 Nov 8, 2019
11 of 12 checks passed
11 of 12 checks passed
tide Not mergeable. Should not have do-not-merge/cherry-pick-not-approved label.
Details
cla/linuxfoundation yutedz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@liggitt liggitt deleted the liggitt:automated-cherry-pick-of-#84693-upstream-release-1.15 branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.