Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json patch limit check #84963

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@liggitt
Copy link
Member

liggitt commented Nov 8, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes bounds checking of large json patches.

Which issue(s) this PR fixes:
Fixes #84908

Special notes for your reviewer:
Builds on #84916

Does this PR introduce a user-facing change?:

kube-apiserver: Fixed a regression accepting patch requests > 1MB
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Nov 8, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Nov 8, 2019

opened picks to 1.14, 1.15, 1.16 to get CI running

@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented Nov 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 15f586a into kubernetes:master Nov 8, 2019
15 of 16 checks passed
15 of 16 checks passed
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@liggitt liggitt deleted the liggitt:feature-json-codes branch Nov 8, 2019
k8s-ci-robot added a commit that referenced this pull request Nov 8, 2019
…3-upstream-release-1.16

Automated cherry pick of #84963: json unmarshal coded error at function applyJSPatch()
k8s-ci-robot added a commit that referenced this pull request Nov 8, 2019
…3-upstream-release-1.15

Automated cherry pick of #84963: json unmarshal coded error at function applyJSPatch()
k8s-ci-robot added a commit that referenced this pull request Nov 8, 2019
…3-upstream-release-1.14

Automated cherry pick of #84963: json unmarshal coded error at function applyJSPatch()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.