Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
- Delete backing string set from a threadSafeMap index when the string set length reaches 0. #84970
What type of PR is this?
What this PR does / why we need it:
Reduce memory footprint of
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Hi @pdzwart-atlassian. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
1 similar comment
…g set length reaches 0. - Added thread_safe_store_test exercising new index backing string set delete at 0 functionality. - TestThreadSafeStoreDeleteRemovesEmptySetsFromIndex logic nesting inverted. - Added test case for usage of an index where post element delete there is non-zero count of elements and expect the set to still exist. - Fixed date. - Fixed awprice nits. - Fix bazel.