Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Splitting IP address type into IPv4 and IPv6 for EndpointSlices #84971
What type of PR is this?
What this PR does / why we need it:
I believe this will be a backwards compatible change since kube-proxy in 1.16 does not actually validate/filter on EndpointSlice address types, so as long as the controller is upgraded to 1.17 before kube-proxy, everything should work well.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
I focused on API. It seems the contention is really around whether AddressType needs to be immutable and whether a default is valuable or not.
I don't think a default is valuable any more - let's be explicit.
I am ambivalent about immutability. It doesn't feel particularly important, but also unlikely to matter either way. POLS seems like it should be mutable and validated.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
1 similar comment
this is potentially failing pull-kubernetes-verify in the merge queue
Somehow the presubmit tests must have passed for that PR despite it making a change to types without actually updating
I think all of that combined with tests passing here and failing on the other PR make it reasonable to remove the hold on this one. Feel free to add it back if I missed something. Thanks for the help trying to get the merge queue moving again!