Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resource constraints #84975

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@mkumatag
Copy link
Member

mkumatag commented Nov 8, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature

/kind flake

What this PR does / why we need it:
Hitting with OOM issues on few environments, we don't need resource limits here anyways for these testscase, in the past, we have seen a couple of PRs already wrt to bumping the memory limits.
#36771
#66562

I'm just removing the memory limits from these testcases to avoid any flaky in the future.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
@mkumatag

This comment has been minimized.

Copy link
Member Author

mkumatag commented Nov 8, 2019

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing and removed needs-sig labels Nov 8, 2019
@mkumatag

This comment has been minimized.

Copy link
Member Author

mkumatag commented Nov 8, 2019

/assign @derekwaynecarr

@mkumatag

This comment has been minimized.

Copy link
Member Author

mkumatag commented Nov 8, 2019

/assign @tallclair
/assign @yujuhong

@mkumatag

This comment has been minimized.

Copy link
Member Author

mkumatag commented Nov 8, 2019

/priority failing-test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 8, 2019

@mkumatag: The label(s) priority/failing-test cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/priority failing-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkumatag

This comment has been minimized.

Copy link
Member Author

mkumatag commented Nov 8, 2019

/priority important-longterm

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 11, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 11, 2019
Copy link
Member

oomichi left a comment

Looks good to me for removing memory limitation line, but just one question.

test/e2e/common/init_container.go Show resolved Hide resolved
@oomichi

This comment has been minimized.

Copy link
Member

oomichi commented Nov 12, 2019

/cc @oomichi

@k8s-ci-robot k8s-ci-robot requested a review from oomichi Nov 12, 2019
@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Nov 13, 2019

if we are only dealing with OOM , agree we should only remove memory and keep cpu. If you can make the update we can tag.

@mkumatag mkumatag force-pushed the mkumatag:fix-initcontainers branch from 179b51c to d519d55 Nov 13, 2019
@k8s-ci-robot k8s-ci-robot removed the size/S label Nov 13, 2019
@mkumatag

This comment has been minimized.

Copy link
Member Author

mkumatag commented Nov 13, 2019

if we are only dealing with OOM , agree we should only remove memory and keep cpu. If you can make the update we can tag.

done, removed only memory limits.

@mkumatag mkumatag force-pushed the mkumatag:fix-initcontainers branch from d519d55 to de48309 Nov 13, 2019
@mkumatag

This comment has been minimized.

Copy link
Member Author

mkumatag commented Nov 13, 2019

/retest

@mkumatag

This comment has been minimized.

Copy link
Member Author

mkumatag commented Nov 13, 2019

@oomichi @derekwaynecarr fixed the review comments and tests are all green now, can you PTAL?

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Nov 13, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 13, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c85bde1 into kubernetes:master Nov 13, 2019
16 checks passed
16 checks passed
cla/linuxfoundation mkumatag authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.