Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftover factory directory #84996

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@alculquicondor
Copy link
Member

alculquicondor commented Nov 8, 2019

/kind cleanup

What this PR does / why we need it:

Remove leftover directory from recent refactorings merging factory into scheduler package.

Does this PR introduce a user-facing change?:

NONE
@alculquicondor

This comment has been minimized.

Copy link
Member Author

alculquicondor commented Nov 8, 2019

/assign @ahg-g

Signed-off-by: Aldo Culquicondor <acondor@google.com>
@alculquicondor alculquicondor force-pushed the alculquicondor:cleanup/rm_factory branch from d649a61 to efe9392 Nov 8, 2019
@alculquicondor

This comment has been minimized.

Copy link
Member Author

alculquicondor commented Nov 8, 2019

/priority backlog

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Nov 11, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 11, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 268663c into kubernetes:master Nov 11, 2019
15 checks passed
15 checks passed
cla/linuxfoundation alculquicondor authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 11, 2019
robscott added a commit to robscott/kubernetes that referenced this pull request Nov 11, 2019
…ctory

Remove leftover factory directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.