Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken links https://kubernetes-csi.github.io/docs/Drivers.html #85163

Closed
wants to merge 0 commits into from

Conversation

@CriaHu
Copy link
Contributor

CriaHu commented Nov 13, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind documentation

What this PR does / why we need it:
fix broken links
Which issue(s) this PR fixes:

Fixes #
NONE
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 13, 2019

Hi @CriaHu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Nov 13, 2019

/test pull-kubernetes-e2e-gce-device-plugin-gpu
/assign @smarterclayton
/ok-to-test
/kind documentation

@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Nov 14, 2019

@liggitt can you review this pr?thanks!

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 14, 2019

also CHANGELOG-1.10.md, right?

@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Nov 15, 2019

@liggitt Sure.You are Right.
@CriaHu Please fix-up the same question in CHANGELOG-1.10.md.Thanks.

@CriaHu

This comment has been minimized.

Copy link
Contributor Author

CriaHu commented Nov 15, 2019

@tanjunchen
the same question in CHANGELOG-1.10.md is in this #85086

@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Nov 15, 2019

@CriaHu OK. But you can't fix-up the same problems in different pr.
advice: add CHANGELOG-1.10.md in this pr and close another pr.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 15, 2019
@CriaHu

This comment has been minimized.

Copy link
Contributor Author

CriaHu commented Nov 15, 2019

@tanjunchen Ok.I haved increased a new commit in this pr.

@CriaHu

This comment has been minimized.

Copy link
Contributor Author

CriaHu commented Nov 15, 2019

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 15, 2019
@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Nov 18, 2019

/test pull-kubernetes-node-e2e-containerd

@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Nov 18, 2019

@liggitt right now?

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 18, 2019

/lgtm
/approve
/priority backlog

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 18, 2019

/sig storage

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 20, 2019

New changes are detected. LGTM label has been removed.

@CriaHu

This comment has been minimized.

Copy link
Contributor Author

CriaHu commented Nov 20, 2019

@liggitt,can you help me merge this pr?

@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Nov 21, 2019

@CriaHu Don't worry, hold on, now the code is hosted and the code will be merged soon.

@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Nov 21, 2019

ref:#85495

@tanjunchen tanjunchen mentioned this pull request Nov 21, 2019
@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Nov 22, 2019
@CriaHu CriaHu closed this Nov 22, 2019
@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Nov 22, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CriaHu, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

@CriaHu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration 3c5dad6 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.