Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: move LogFailedContainers out of e2e test framework util.go #85200

Merged
merged 1 commit into from Nov 25, 2019
Merged

e2e: move LogFailedContainers out of e2e test framework util.go #85200

merged 1 commit into from Nov 25, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Nov 13, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Move LogFailedContainers out of e2e test framework util.go.
To resolve circular references, this PR also handles rc_util.go.

/cc @oomichi @MorrisLaw

Which issue(s) this PR fixes:

Ref #84615

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 13, 2019
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 13, 2019
@k8s-ci-robot
Copy link
Contributor

@SataQiu: GitHub didn't allow me to request PR reviews from the following users: MorrisLaw.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Move LogFailedContainers out of e2e test framework util.go.
To resolve circular references, this PR also handles rc_util.go.

/cc @oomichi @MorrisLaw

Which issue(s) this PR fixes:

Ref #84615

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 13, 2019
oomichi
oomichi reviewed Nov 13, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself seems good for me because this doesn't add any invalid dependencies and good separation from the core framework.
Just one comment about a lint error.

test/e2e/framework/rc/rc_utils.go
@@ -26,6 +26,8 @@ import (
clientset "k8s.io/client-go/kubernetes"
scaleclient "k8s.io/client-go/scale"
api "k8s.io/kubernetes/pkg/apis/core"
"k8s.io/kubernetes/test/e2e/framework"
e2ekubectl "k8s.io/kubernetes/test/e2e/framework/kubectl"
testutils "k8s.io/kubernetes/test/utils"
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to rename RcByNameContainer for solving the following lint error:

test/e2e/framework/rc/rc_utils.go:35:6: func name will be used as rc.RcByNameContainer by other packages, and that stutters; consider calling this ByNameContainer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oomichi
Updated.

@SataQiu SataQiu force-pushed the refactor-e2e-kubectl-20191113 branch from 1ae784a to 610d982 Compare November 14, 2019 07:37
@SataQiu
Copy link
Member Author

SataQiu commented Nov 14, 2019

/test pull-kubernetes-e2e-gce

oomichi
oomichi reviewed Nov 14, 2019
View reviewed changes
Copy link
Member

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2019
@SataQiu SataQiu force-pushed the refactor-e2e-kubectl-20191113 branch from 610d982 to 50bc528 Compare November 15, 2019 02:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Nov 15, 2019

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-node-e2e-containerd

@MorrisLaw
Copy link
Member

/test pull-kubernetes-node-e2e-containerd

@MorrisLaw
Copy link
Member

Looking good @SataQiu , I'm not sure why it failed. I re-ran it again, maybe it's a flakey test?

@dims
Copy link
Member

dims commented Nov 15, 2019

/milestone v1.18

looks like we missed the boat. let's try after code thaw

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 15, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Nov 16, 2019

@MorrisLaw Yes, I'm also confused why the test didn't pass.
/test pull-kubernetes-node-e2e-containerd

@SataQiu
Copy link
Member Author

SataQiu commented Nov 23, 2019

@oomichi Need LGTM again :)

@hwdef
Copy link
Member

hwdef commented Nov 25, 2019

/lgtm
Thanks for your contribute!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2019
@hwdef
Copy link
Member

hwdef commented Nov 25, 2019

/test tide

@hwdef
Copy link
Member

hwdef commented Nov 25, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit c7c0d09 into kubernetes:master Nov 25, 2019
@k8s-ci-robot
Copy link
Contributor

@SataQiu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big 50bc528 link /test pull-kubernetes-kubemark-e2e-gce-big

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MorrisLaw MorrisLaw mentioned this pull request Dec 7, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oomichi oomichi oomichi left review comments

Assignees

@oomichi oomichi

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SataQiu @k8s-ci-robot @MorrisLaw @dims @hwdef @oomichi