Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow show hidden metrics in kube-proxy #85279

Merged

Conversation

@RainbowMango
Copy link
Member

RainbowMango commented Nov 14, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add a flag --show-hidden-metrics-for-version to kube-proxy for show hidden metrics.

Which issue(s) this PR fixes:
Part of #85270

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

New flag `--show-hidden-metrics-for-version` in kube-proxy can be used to show all hidden metrics that deprecated in the previous minor release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190404-kubernetes-control-plane-metrics-stability.md
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 14, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@RainbowMango RainbowMango mentioned this pull request Nov 14, 2019
3 of 5 tasks complete
@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Nov 15, 2019

/test pull-kubernetes-node-e2e-containerd

1 similar comment
@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Nov 18, 2019

/test pull-kubernetes-node-e2e-containerd

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Nov 18, 2019

/hold
We need to solve the issue first.

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Nov 26, 2019

/assign @thockin
/cc @brancz @logicalhan

/hold cancel

@@ -149,6 +149,12 @@ func (o *Options) AddFlags(fs *pflag.FlagSet) {
fs.StringVar(&o.master, "master", o.master, "The address of the Kubernetes API server (overrides any value in kubeconfig)")
fs.StringVar(&o.hostnameOverride, "hostname-override", o.hostnameOverride, "If non-empty, will use this string as identification instead of the actual hostname.")
fs.StringVar(&o.config.IPVS.Scheduler, "ipvs-scheduler", o.config.IPVS.Scheduler, "The ipvs scheduler type when proxy mode is ipvs")
fs.StringVar(&o.config.ShowHiddenMetricsForVersion, "show-hidden-metrics-for-version", o.config.ShowHiddenMetricsForVersion,
"The previous version for which you want to show hidden metrics. "+
"Only the previous minor version is meaningful, other values will not be allowed. "+

This comment has been minimized.

Copy link
@thockin

thockin Dec 2, 2019

Member

I know this is part of a larger effort, but this comment is confusing to me.

If it only allows the previous version, why do I have to specify a version?

This comment has been minimized.

Copy link
@RainbowMango

RainbowMango Dec 3, 2019

Author Member

First of all, this flag is an escape hatch, it intends to be used by admins if they were not able to react to the earlier deprecation warnings.

Second of all, we don't want admins to be excessive depend on this flag, otherwise, they may fail to notice deprecate message from the next release.

Here is an example: why-not-bool-flag

@thockin

Copy link
Member

thockin left a comment

Thanks!

/lgtm
/approve

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Dec 17, 2019

/test pull-kubernetes-bazel-test

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Dec 17, 2019

/hold

I think this PR is failing pull-kubernetes-bazel-test in the merge queue

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Dec 17, 2019

I think this PR is failing pull-kubernetes-bazel-test in the merge queue

Is there an issue tracking this failing test? Or, what can I do for this?

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Dec 17, 2019

I think this PR is failing pull-kubernetes-bazel-test in the merge queue

Is there an issue tracking this failing test? Or, what can I do for this?

you need to fix your PR, please look at the reason here: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/85279/pull-kubernetes-bazel-test/1206771457862930432

- Update bazel by hack/update-bazel.sh
- make update
@RainbowMango RainbowMango force-pushed the RainbowMango:pr_add_metrics_flag_to_proxy branch from 58d8d19 to 4eb61e3 Dec 17, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 17, 2019
@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Dec 17, 2019

Just rebase master and force-push, let's see what happens.

I don't know why bazel test failing in merge pool, no idea from logs, it's weird.

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Dec 17, 2019

pull-kubernetes-bazel-test failing due to new unit test added by #84688.

I haven't go through the whole PR, @tahsinrahman can you help take a look?

Fix proxy unit test
@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Dec 18, 2019

New commit is specially for fix unit tests.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Dec 18, 2019

/test pull-kubernetes-e2e-gce

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Dec 18, 2019

/lgtm

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Dec 18, 2019

/hold cancel
@ahg-g Thanks for your help. Let's continue after unit test has been fixed.

@RainbowMango

This comment has been minimized.

Copy link
Member Author

RainbowMango commented Dec 18, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 2796ff8 into kubernetes:master Dec 18, 2019
12 of 15 checks passed
12 of 15 checks passed
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation RainbowMango authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 18, 2019
@RainbowMango RainbowMango deleted the RainbowMango:pr_add_metrics_flag_to_proxy branch Dec 18, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 18, 2019

@RainbowMango: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 6b33a77 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.