Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show-hidden-metrics-for-version to kubelet #85282

Merged
merged 1 commit into from Feb 26, 2020

Conversation

@serathius
Copy link
Contributor

serathius commented Nov 14, 2019

/kind feature
Ref #85270

Does this PR introduce a user-facing change?:

New flag `--show-hidden-metrics-for-version` in kubelet can be used to show all hidden metrics that deprecated in the previous minor release.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-instrumentation/20190404-kubernetes-control-plane-metrics-stability.md

/cc @RainbowMango

Copy link
Contributor

mattjmcnaughton left a comment

/unacc

Not sure I have the context to provide the requested review :)

At a high level, this implementation seems to be inline with the plan discussed in the KEP here. Wondering if the instrumentation folks who commented on the KEP should be the ones to give the sign-off?

cc @logicalhan @brancz

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

mattjmcnaughton commented Nov 15, 2019

/test pull-kubernetes-node-e2e-containerd

Also, please rebase this diff when you get the chance :) thanks!

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Nov 16, 2019

Looks good from instrumentation.

/lgtm

@RainbowMango

This comment has been minimized.

Copy link
Member

RainbowMango commented Nov 18, 2019

/test pull-kubernetes-node-e2e-containerd

@RainbowMango

This comment has been minimized.

Copy link
Member

RainbowMango commented Nov 18, 2019

/hold
We need to solve the issue first.

@RainbowMango

This comment has been minimized.

Copy link
Member

RainbowMango commented Nov 26, 2019

@serathius
Please rebase and solve the conflicts. :)

/hold cancel
/milestone v1.18
/priority important-soon
/assign @yujuhong @dashpole

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Nov 26, 2019

You will want to add this to the kubelet component configuration as well:
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/config/types.go#L74

You can probably follow this change as an example:
89dfd24#diff-5088ffe9a3539b287e74e2ca03c5090c

@serathius serathius force-pushed the serathius:flag-kubelet branch from 9f9cad4 to cdeaedd Dec 9, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 9, 2019
@serathius serathius force-pushed the serathius:flag-kubelet branch from 42a8e6b to 03d6de7 Feb 5, 2020
@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented Feb 5, 2020

/retest

1 similar comment
@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented Feb 12, 2020

/retest

@RainbowMango

This comment has been minimized.

Copy link
Member

RainbowMango commented Feb 14, 2020

It seems this ready to go now.
@dashpole Can you take a look again.

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Feb 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 17, 2020
@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented Feb 18, 2020

@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented Feb 21, 2020

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Feb 24, 2020

/approve

@serathius serathius force-pushed the serathius:flag-kubelet branch from 03d6de7 to ee8f0a4 Feb 25, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 25, 2020
@serathius serathius force-pushed the serathius:flag-kubelet branch from ee8f0a4 to d44d5b3 Feb 25, 2020
@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Feb 25, 2020
@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Feb 25, 2020

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, serathius, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RainbowMango

This comment has been minimized.

Copy link
Member

RainbowMango commented Feb 26, 2020

/lgtm

@RainbowMango

This comment has been minimized.

Copy link
Member

RainbowMango commented Feb 26, 2020

/test pull-kubernetes-e2e-gce-100-performance

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 26, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@serathius

This comment has been minimized.

Copy link
Contributor Author

serathius commented Feb 26, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6ec3ea8 into kubernetes:master Feb 26, 2020
14 of 16 checks passed
14 of 16 checks passed
pull-kubernetes-e2e-gce Job triggered.
Details
tide Not mergeable. Job pull-kubernetes-e2e-gce has not succeeded.
Details
cla/linuxfoundation serathius authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.