Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included FSType in CSI volumes #85293

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@huffmanca
Copy link
Contributor

huffmanca commented Nov 14, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Other volume types display the FSType when displayed using kubectl describe. This PR updates CSI PVs to display FSType as well.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Includes FSType when describing CSI persistent volumes.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 14, 2019

Hi @huffmanca. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from deads2k and dims Nov 14, 2019
@huffmanca

This comment has been minimized.

Copy link
Contributor Author

huffmanca commented Nov 14, 2019

/sig storage

@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Nov 14, 2019

/ok-to-test

@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Nov 14, 2019

/lgtm

@huffmanca

This comment has been minimized.

Copy link
Contributor Author

huffmanca commented Nov 14, 2019

/retest

@dims

This comment has been minimized.

Copy link
Member

dims commented Nov 16, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims Nov 16, 2019
@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Nov 28, 2019

/assign @soltysh
for approval, this is a simple consistency fix.

@soltysh
soltysh approved these changes Dec 3, 2019
Copy link
Contributor

soltysh left a comment

/approve
/priority important-longterm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 3, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 2b6857d into kubernetes:master Dec 3, 2019
13 of 15 checks passed
13 of 15 checks passed
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation huffmanca authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.