Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize FeatureGate map for KubeProxy config. #1929 #85524

Conversation

@Arvinderpal
Copy link
Contributor

Arvinderpal commented Nov 22, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
kubernetes/kubeadm#1929

Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#1929

Does this PR introduce a user-facing change?:

kubeadm: fix a panic in case the KubeProxyConfiguration feature gates were not initialized.

@neolit123 @rosti

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

Hi @Arvinderpal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rosti
rosti approved these changes Nov 22, 2019
Copy link
Member

rosti left a comment

Thanks @Arvinderpal !
Can you also add a release note to the PR?
/ok-to-test
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Arvinderpal, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rosti

This comment has been minimized.

Copy link
Member

rosti commented Nov 22, 2019

/retest

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 22, 2019

/priority important-soon
/milestone v1.17

Can you also add a release note to the PR?

yes, something in the lines of:

kubeadm: fix a panic in case the KubeProxyConfiguration feature gates were not initialized

@Arvinderpal

This comment has been minimized.

Copy link
Contributor Author

Arvinderpal commented Nov 22, 2019

@neolit123 I added the release note.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 22, 2019

do-not-merge/release-note-label-needed

@Arvinderpal
release notes need to follow a special formatting using a release-note block
please see here:
https://raw.githubusercontent.com/kubernetes/kubernetes/master/.github/PULL_REQUEST_TEMPLATE.md

@Arvinderpal

This comment has been minimized.

Copy link
Contributor Author

Arvinderpal commented Nov 22, 2019

Done.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 22, 2019

thanks
/lgtm

i will send backport for 1.16

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3028dc1 into kubernetes:master Nov 22, 2019
14 of 15 checks passed
14 of 15 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation Arvinderpal authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@Arvinderpal Arvinderpal mentioned this pull request Nov 27, 2019
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.