Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Revert "kube-proxy: check KUBE-MARK-DROP" #85527
What type of PR is this?
What this PR does / why we need it:
This reverts commit 1ca0ffe.
kube-proxy is not recreating the rules associated to the
Is preferrable to avoid the dependency between the kubelet and
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is only needed for kube-proxy operating in dual-stack with iptables, and that PR wasn't merged.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
@aojea: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.
Ugh, yeah, it looks like every time the proxier syncs, it deletes the contents of kubelet's
So this fix is correct, and removing it won't break anything (because it was only half of the fix anyway) and this is absolutely needed for 1.17, beyond just fixing the flaky test.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing