Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup conversions in kubectl #85556

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@wojtek-t
Copy link
Member

wojtek-t commented Nov 22, 2019

Ref #84452

ToUnstructured/FromUnstructured doesn't assume that a bunch of predefined conversions are registered.

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wojtek-t wojtek-t force-pushed the wojtek-t:fix_kubectl_conversions branch from 4a27abf to bfa4188 Nov 22, 2019
@wojtek-t

This comment has been minimized.

Copy link
Member Author

wojtek-t commented Nov 25, 2019

/assign @soltysh

@soltysh - can you please take a look (fairly small PR and should be no-op)

Copy link
Contributor

soltysh left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 25, 2019
@wojtek-t wojtek-t added this to the v1.18 milestone Nov 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit c318482 into kubernetes:master Nov 25, 2019
15 checks passed
15 checks passed
cla/linuxfoundation wojtek-t authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@wojtek-t wojtek-t deleted the wojtek-t:fix_kubectl_conversions branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.