Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
kubectl/drain: add option skip-wait-for-delete-timeout #85577
What type of PR is this?
What this PR does / why we need it:
We should allow drain to ignore pods that have a
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @michaelgugino. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
Currently, some circumstances may cause waitForDelete to never succeed after the pod has been marked for deletion. In particular, Nodes that are unresponsive and have pods with local-storage will not be able to successfully drain. We should allow drain to ignore pods that have a DeletionTimestamp older than a user-provided age. This will allow controllers utilizing kubectl/drain to optionally account for a pod that cannot be removed due to a misbehaving node.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing