Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apply --prune to visit cli specified namespace #85613

Conversation

@MartinKaburu
Copy link
Contributor

MartinKaburu commented Nov 25, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
It fixes a bug that causes kubectl apply --prune -n <namespace> to fail since it does not check the cli specified namespace.

Which issue(s) this PR fixes:
Fixes #85357

Does this PR introduce a user-facing change?:

`kubectl apply  -f <file> --prune -n <namespace>` should prune all resources not defined in the file in the cli specified namespace.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 25, 2019

Hi @MartinKaburu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 26, 2019

/ok-to-test
/priority backlog

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Nov 26, 2019

Does this PR introduce a user-facing change?:
None

instead of "none" please explain the change in a single sentence (release note).

@MartinKaburu

This comment has been minimized.

Copy link
Contributor Author

MartinKaburu commented Nov 26, 2019

/test pull-kubernetes-verify

@MartinKaburu

This comment has been minimized.

Copy link
Contributor Author

MartinKaburu commented Nov 26, 2019

/test pull-kubernetes-e2e-gce

@MartinKaburu

This comment has been minimized.

Copy link
Contributor Author

MartinKaburu commented Nov 26, 2019

/test pull-kubernetes-verify

1 similar comment
@MartinKaburu

This comment has been minimized.

Copy link
Contributor Author

MartinKaburu commented Nov 26, 2019

/test pull-kubernetes-verify

@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Nov 27, 2019

Also that verify failure is legit, the gofmt is messed up.

@MartinKaburu MartinKaburu force-pushed the MartinKaburu:fix-apply-prune-to-visit-cli-specified-namespace branch from 79a85b6 to 20d0558 Dec 3, 2019
@MartinKaburu MartinKaburu force-pushed the MartinKaburu:fix-apply-prune-to-visit-cli-specified-namespace branch 3 times, most recently from 0433c99 to f2cd4d2 Dec 5, 2019
@soltysh
soltysh approved these changes Jan 9, 2020
Copy link
Contributor

soltysh left a comment

/lgtm
/approve
/hold
for the rebase

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinKaburu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MartinKaburu MartinKaburu force-pushed the MartinKaburu:fix-apply-prune-to-visit-cli-specified-namespace branch from f2cd4d2 to 396a1f9 Jan 9, 2020
@MartinKaburu MartinKaburu force-pushed the MartinKaburu:fix-apply-prune-to-visit-cli-specified-namespace branch from 0e7d21c to ecf5758 Jan 9, 2020
@MartinKaburu MartinKaburu force-pushed the MartinKaburu:fix-apply-prune-to-visit-cli-specified-namespace branch from ecf5758 to f251834 Jan 9, 2020
@MartinKaburu

This comment has been minimized.

Copy link
Contributor Author

MartinKaburu commented Jan 9, 2020

/retest

@MartinKaburu

This comment has been minimized.

Copy link
Contributor Author

MartinKaburu commented Jan 9, 2020

/test pull-kubernetes-e2e-gce

Copy link
Contributor

soltysh left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 15, 2020
@soltysh

This comment has been minimized.

Copy link
Contributor

soltysh commented Jan 15, 2020

/hold cancel

@MartinKaburu

This comment has been minimized.

Copy link
Contributor Author

MartinKaburu commented Jan 15, 2020

/retest tide

@k8s-ci-robot k8s-ci-robot merged commit 0520931 into kubernetes:master Jan 15, 2020
16 checks passed
16 checks passed
cla/linuxfoundation MartinKaburu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.