Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-winio module version from 0.4.11 to 0.4.14 #85739

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@wawa0210
Copy link
Contributor

wawa0210 commented Nov 29, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind cleanup

What this PR does / why we need it:

Update go mod go-winio version to Improve windows ListenPipe stability . The kubernetes code as https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/util/util_windows.go#L38-L54.
go-winio fixed this in 0.4.13. An a race condition where ListenPipe can fail due to concurrent DialPipe calls. We can check the details through https://github.com/microsoft/go-winio/releases/tag/v0.4.13

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update go-winio module version from 0.4.11 to 0.4.14

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@jterry75
/sig windows

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 29, 2019

Hi @wawa0210. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from lavalamp, thockin and kubernetes/dep-approvers Nov 29, 2019
@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Nov 29, 2019

/ok-to-test

@jterry75

This comment has been minimized.

Copy link

jterry75 commented Dec 2, 2019

LGTM (not a maintainer)

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Dec 3, 2019

/lgtm
/approve

@wawa0210

This comment has been minimized.

Copy link
Contributor Author

wawa0210 commented Dec 4, 2019

/assign @lavalamp
/assign @liggitt

@PatrickLang PatrickLang added this to Backlog (v1.18) in SIG-Windows Dec 6, 2019
@PatrickLang PatrickLang moved this from Backlog (v1.18) to In Progress (v1.18) in SIG-Windows Dec 6, 2019
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 6, 2019

/approve
/kind bug
/priority important-longterm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 220e2ce into kubernetes:master Dec 6, 2019
15 checks passed
15 checks passed
cla/linuxfoundation wawa0210 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
SIG-Windows automation moved this from In Progress (v1.18) to Done (v1.18) Dec 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 6, 2019
@wawa0210 wawa0210 deleted the wawa0210:update-go-winio branch Dec 7, 2019
@wawa0210 wawa0210 mentioned this pull request Jan 17, 2020
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.