Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExpectEqual test/e2e_node #85787

Merged

Conversation

@tanjunchen
Copy link
Member

tanjunchen commented Dec 2, 2019

What type of PR is this?

/kind cleanup
/priority backlog
/release-note-none

What this PR does / why we need it:

This makes e2e tests use the function under test/e2e_node

Which issue(s) this PR fixes:

Ref: #79686

Special notes for your reviewer:

/cc @oomichi

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None
@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Dec 2, 2019

/assign @tallclair

@@ -600,6 +600,7 @@ func verifyEvictionOrdering(f *framework.Framework, testSpecs []podEvictSpec) er
}
}
gomega.Expect(priorityPod).NotTo(gomega.BeNil())

This comment has been minimized.

Copy link
@oomichi

oomichi Dec 3, 2019

Member

unnecessary addition..

This comment has been minimized.

Copy link
@tanjunchen

tanjunchen Dec 3, 2019

Author Member

ok.Sorry,i will pay attention to this condiction

@tanjunchen tanjunchen force-pushed the tanjunchen:use-ExpectEqual-test-e2e_node branch from 2c69b3a to a10c479 Dec 3, 2019
@tanjunchen tanjunchen force-pushed the tanjunchen:use-ExpectEqual-test-e2e_node branch from a10c479 to 561ee6e Dec 3, 2019
@hwdef

This comment has been minimized.

Copy link
Member

hwdef commented Dec 3, 2019

/test pull-kubernetes-e2e-gce

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Dec 4, 2019

/cc @oomichi
done

@k8s-ci-robot k8s-ci-robot requested a review from oomichi Dec 4, 2019
@oomichi

This comment has been minimized.

Copy link
Member

oomichi commented Dec 4, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f47e4ae into kubernetes:master Dec 4, 2019
16 checks passed
16 checks passed
cla/linuxfoundation tanjunchen authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 4, 2019
@Random-Liu

This comment has been minimized.

Copy link
Member

Random-Liu commented Dec 5, 2019

This breaks node e2e test. https://k8s-testgrid.appspot.com/sig-node-kubelet#node-kubelet-features

@tanjunchen @oomichi can we fix it or revert this?

@Random-Liu

This comment has been minimized.

Copy link
Member

Random-Liu commented Dec 5, 2019

This is breaking CI and containerd presubmit containerd/cri#1349.

BeNil and BeZero are still needed, and can't be simply replaced by Equal because of the type conversion.

I would revert this change for now.

We can consider either add BeNil and BeZero into our framework, or keep the current code and only change places that make sense to use Equal.

@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Dec 5, 2019

@Random-Liu
Sure, revert this. We will pay attention to this condiction next time.

@Random-Liu

This comment has been minimized.

Copy link
Member

Random-Liu commented Dec 5, 2019

@tanjunchen Thanks a lot! :D

@xueweiz

This comment has been minimized.

Copy link
Contributor

xueweiz commented Dec 5, 2019

Hi @Random-Liu , I filed a bug at #85933 and uploaded a fix at #85934 :)

@tanjunchen tanjunchen deleted the tanjunchen:use-ExpectEqual-test-e2e_node branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.