Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unnecessary nil check in if statement in nodelease controller #85789
Conversation
This comment has been minimized.
This comment has been minimized.
@ZP-AlwaysWin: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This comment has been minimized.
This comment has been minimized.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ZP-AlwaysWin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This comment has been minimized.
This comment has been minimized.
/assgin @feiskyer |
/lgtm Small nit: I think "Remove unnecessary nil check in if statement in nodelease controller` could be a slightly more descriptive pr title. |
This comment has been minimized.
This comment has been minimized.
Thanks,I hava changed pr title. |
This comment has been minimized.
This comment has been minimized.
/assign @Random-Liu |
ZP-AlwaysWin commentedDec 2, 2019
•
edited
What type of PR is this?
Remove unnecessary judgment
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: