Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix staticcheck in pkg/printers #85790

Merged

Conversation

@tanjunchen
Copy link
Member

tanjunchen commented Dec 2, 2019

What type of PR is this?

/priority backlog
/kind cleanup

What this PR does / why we need it:

fix staticcheck pkg/printers

Which issue(s) this PR fixes:

Ref: #81657

Special notes for your reviewer:

tablegenerator.go:48:2: field args is unused (U1000)
tablegenerator.go:162:20: error strings should not end with punctuation or a newline (ST1005)

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Dec 2, 2019

/priority backlog
/release-note-none
/assign @liggitt
/assign @soltysh

@tanjunchen tanjunchen force-pushed the tanjunchen:fix-staticcheck-pkg-printers branch from 88157b3 to 40911e7 Dec 5, 2019
@tanjunchen

This comment has been minimized.

Copy link
Member Author

tanjunchen commented Dec 5, 2019

/test pull-kubernetes-e2e-gce

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 5, 2019

/lgtm
/approve
/sig api-machinery

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c2b312b into kubernetes:master Dec 5, 2019
15 checks passed
15 checks passed
cla/linuxfoundation tanjunchen authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.