Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find plugin when configuration given on command line #85796

Open
wants to merge 1 commit into
base: master
from

Conversation

@oke-py
Copy link
Member

oke-py commented Dec 2, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
When flags are given before plugin command, kubectl fails to find the plugin.
As a result, it returns incorrect error message.

$ kubectl --kubeconfig ~/.kube/config krew list
Error: unknown command "krew" for "kubectl"
Run 'kubectl --help' for usage.

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#727

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

find plugin when configuration given on command line

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oke-py
To complete the pull request process, please assign brendandburns
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@oke-py

This comment has been minimized.

Copy link
Member Author

oke-py commented Dec 2, 2019

/assign @brendandburns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.