Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to specify kubelet flags for heapster node. #85797

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@oxddr
Copy link
Contributor

oxddr commented Dec 2, 2019

Useful in scalability tests, where we don't want test pods (e.g. Kubemark hollow nodes) to be scheduled on heapster node.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
See #85683

Which issue(s) this PR fixes: n/a

Special notes for your reviewer: n/a

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: n/a

/sig scalability
/priority important-soon
/milestone v1.18
/assign @wojtek-t

@oxddr

This comment has been minimized.

Copy link
Contributor Author

oxddr commented Dec 2, 2019

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-device-plugin-gpu

@oxddr oxddr force-pushed the oxddr:taint-heapster branch from 84207f6 to cb4405f Dec 2, 2019
@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Dec 2, 2019

The failures look related

@oxddr

This comment has been minimized.

Copy link
Contributor Author

oxddr commented Dec 3, 2019

/test pull-kubernetes-e2e-gce-100-performance

Failure from pull-kubernetes-e2e-gce-100-performance seem unrelated.

@oxddr oxddr force-pushed the oxddr:taint-heapster branch 3 times, most recently from 371c6b3 to b03f751 Dec 3, 2019
@oxddr

This comment has been minimized.

Copy link
Contributor Author

oxddr commented Dec 5, 2019

/assign @jkaniuk

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Dec 5, 2019

@oxddr - I've seen that PR, but before I will look into it, I would like tests to pass

@yujuhong

This comment has been minimized.

Copy link
Member

yujuhong commented Dec 5, 2019

Could you explain why this PR is needed and what's a "heapster" node exactly?

@oxddr

This comment has been minimized.

Copy link
Contributor Author

oxddr commented Dec 6, 2019

@wojtek-t: I've assigned @jkaniuk to possibly find a bug in my code - I have no intention to merge this PR without tests passing.

@yujuhong:

  1. "heapster-node" is a node that was historically used for Heapster. It's purpose is to have a dedicate larger node in cluster, where most nodes are small. As an example in scalability test we use single core machines, but we have 32-core node so we can fit bits that scale with the size of cluster (e.g. Prometheus).
  2. Why we need this? In large kubemark tests (type of scalability tests) we need to have a dedicated node to run Prometheus. See: #85683
Useful in scalability tests, where we don't want test pods (e.g. Kubemark hollow
nodes) to be scheduled on heapster node.
@oxddr oxddr force-pushed the oxddr:taint-heapster branch from b03f751 to 39cb822 Dec 6, 2019
@k8s-ci-robot k8s-ci-robot removed the size/S label Dec 6, 2019
@k8s-ci-robot k8s-ci-robot added the size/M label Dec 6, 2019
@oxddr

This comment has been minimized.

Copy link
Contributor Author

oxddr commented Dec 6, 2019

/test pull-kubernetes-e2e-gce

@oxddr

This comment has been minimized.

Copy link
Contributor Author

oxddr commented Dec 6, 2019

@wojtek-t tests are passing now, PTAL

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Dec 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 6, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oxddr, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 616fce7 into kubernetes:master Dec 6, 2019
15 checks passed
15 checks passed
cla/linuxfoundation oxddr authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.