Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deletecollection operation on services #85802

Open
wants to merge 1 commit into
base: master
from

Conversation

@astefanutti
Copy link
Contributor

astefanutti commented Dec 2, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for the deletecollection operation on services.

Does this PR introduce a user-facing change?:

Add support for the `deletecollection` operation on services
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

Hi @astefanutti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RA489

This comment has been minimized.

Copy link
Contributor

RA489 commented Dec 3, 2019

/ok-to-test

@astefanutti astefanutti force-pushed the astefanutti:pr-deletecollection branch from 9abbebb to a6939b4 Dec 3, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 3, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: astefanutti
To complete the pull request process, please assign liggitt
You can assign the PR to them by writing /assign @liggitt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astefanutti

This comment has been minimized.

Copy link
Contributor Author

astefanutti commented Dec 3, 2019

/test pull-kubernetes-verify

@astefanutti astefanutti force-pushed the astefanutti:pr-deletecollection branch from a6939b4 to 1a69b78 Dec 3, 2019
@astefanutti

This comment has been minimized.

Copy link
Contributor Author

astefanutti commented Dec 3, 2019

/test pull-kubernetes-e2e-gce

@astefanutti

This comment has been minimized.

Copy link
Contributor Author

astefanutti commented Dec 3, 2019

/assign @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 3, 2019

This introduces a bug by which deletecollection on services bypasses all the service-specific logic in the overridden Delete method. Before this can be done, all of that logic needs to be moved to a finalizer and the custom Delete method removed.

/hold

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 3, 2019

Additionally, the fact that no tests failed means that this did not add tests exercising the new function sufficiently.

@astefanutti

This comment has been minimized.

Copy link
Contributor Author

astefanutti commented Dec 3, 2019

@liggitt thanks a lot for your quick feedback. You're right about the issue that the the service-specific logic is by-passed. I'll work on adding the finalizer and add some tests ASAP. If you have some guidelines on what's the best approach to add the finalizer, that'd be great. Otherwise I'll try to find my way in the codebase. Thanks again.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 3, 2019

see #65912 for previous attempts
cc @jhorwit2 @kubernetes/sig-network-pr-reviews
/sig network

@k8s-ci-robot k8s-ci-robot added sig/network and removed needs-sig labels Dec 3, 2019
@astefanutti

This comment has been minimized.

Copy link
Contributor Author

astefanutti commented Dec 4, 2019

@liggitt thanks a lot for the pointer. I think that gives me enough context. I'll work on it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.