Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for deletecollection operation on services #85802
Hi @astefanutti. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
The full list of commands accepted by this bot can be found here.
@liggitt thanks a lot for your quick feedback. You're right about the issue that the the service-specific logic is by-passed. I'll work on adding the finalizer and add some tests ASAP. If you have some guidelines on what's the best approach to add the finalizer, that'd be great. Otherwise I'll try to find my way in the codebase. Thanks again.