Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add space in front of url in command desc #85806

Open
wants to merge 1 commit into
base: master
from

Conversation

@beautytiger
Copy link
Contributor

beautytiger commented Dec 2, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
When run command help in kubectl

# kubectl drain -h
Drain node in preparation for maintenance.

 The given node will be marked unschedulable to prevent new pods from arriving. 'drain' evicts the pods if the APIServer
supportshttp://kubernetes.io/docs/admin/disruptions/ . Otherwise, 

See the supportshttp://kubernetes.io/docs are bad formed, url should have space in front, like this:

Drain node in preparation for maintenance.

 The given node will be marked unschedulable to prevent new pods from arriving. 'drain' evicts the pods if the APIServer
supports http://kubernetes.io/docs/admin/disruptions/ . Otherwise, 

this pr fix this and here: https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#drain

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

Hi @beautytiger. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: beautytiger
To complete the pull request process, please assign soltysh
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@beautytiger

This comment has been minimized.

Copy link
Contributor Author

beautytiger commented Dec 2, 2019

/priority backlog
/sig cli

@beautytiger

This comment has been minimized.

Copy link
Contributor Author

beautytiger commented Dec 2, 2019

/assign @soltysh

Copy link
Member

hpandeycodeit left a comment

/lgtm
/ok-to-test

@tanjunchen

This comment has been minimized.

Copy link
Member

tanjunchen commented Dec 4, 2019

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.