Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: make delete protection to namespace kube-node-lease #85807
What type of PR is this?
What this PR does / why we need it:
Namespace kube-system, default and kube-public already protected.
We should alse protect
However, in some conditon, delete
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
Hi @beautytiger. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: beautytiger
The full list of commands accepted by this bot can be found here.
the intent of these namespace protections was to guard namespaces required for the control plane to operate (which could not auto-recover if deleted). that included the default namespace (because that's where the kubernetes service lives) and the kube-system namespace (because that's where the controller credentials for kube-controller-manager live).
it's not clear the node lease namespace qualifies.