Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #85705: Fix iscsi refcounter in the case of no Block iscsi volumes #85813

Conversation

@ralfonso
Copy link
Contributor

ralfonso commented Dec 2, 2019

Cherry pick of #85705 on release-1.17.

#85705: Fix iscsi refcounter in the case of no Block iscsi volumes

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

@ralfonso: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #85705.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

@ralfonso: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

Hi @ralfonso. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from jsafrane and msau42 Dec 2, 2019
@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Dec 2, 2019
@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Dec 2, 2019

/priority important-soon
/kind bug
/ok-to-test

@tpepper

This comment has been minimized.

Copy link
Contributor

tpepper commented Dec 2, 2019

/release-note-none
per parent PR

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Dec 2, 2019

/test pull-kubernetes-integration

@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Dec 3, 2019

/lgtm
/approve

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Dec 5, 2019

We're planning to hold this until 1.17.1 as the approvals missed the cherry pick deadline for 1.17.0.

@jsafrane / @tanjunchen / @kubernetes/sig-storage-pr-reviews -- Would there be any reason to pull it in for 1.17.0 instead? Severity/risk/urgency?

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Dec 5, 2019

Looking at the issue, this sounds like a regression that prevents Pods that use iscsi volumes from being rescheduled on other nodes. That sounds like a serious issue to me.

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Dec 5, 2019

@msau42 -- Thanks for the confirmation! I've bumped the priority and we'll get this in for 1.17.0!

Release Manager approval:
/lgtm
/approve
/hold (to batch merge with #85969)

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, justaugustus, ralfonso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Dec 6, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 1a8a2c8 into kubernetes:release-1.17 Dec 6, 2019
10 of 12 checks passed
10 of 12 checks passed
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation ralfonso authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.