Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start and stop the scheduling queue consistently #85820

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@ahg-g
Copy link
Member

ahg-g commented Dec 2, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind cleanup

What this PR does / why we need it:
Currently the scheduling queue starts when it gets created, and way before the scheduler.Run() is invoked, and it stops when receiving the generic stop signal, which means the queue can close before the scheduler main scheduling routine itself stops, causing errors such as the following in many of our integration tests, especially the benchmarks:

E1202 12:33:48.935243  111452 scheduling_queue.go:844] Error while retrieving next pod from scheduling queue: scheduling queue is closed

This PR makes starting/stopping the queue more deterministic. It starts when scheduler.Run() starts, and stops just before scheduler.Run() exits. This is done by making the queue's stop channel an internal variable that gets closed only when queue.Close() is invoked.

Does this PR introduce a user-facing change?:

NONE

/cc @liu-cong @Huang-Wei

…er the scheduler stops
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liu-cong

This comment has been minimized.

Copy link
Contributor

liu-cong commented Dec 3, 2019

/hold

Please unhold when you are ready to merge.

@liu-cong

This comment has been minimized.

Copy link
Contributor

liu-cong commented Dec 3, 2019

/lgtm

@ahg-g

This comment has been minimized.

Copy link
Member Author

ahg-g commented Dec 3, 2019

/hold cancel

@Huang-Wei

This comment has been minimized.

Copy link
Member

Huang-Wei commented Dec 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b141a99 into kubernetes:master Dec 3, 2019
15 checks passed
15 checks passed
cla/linuxfoundation ahg-g authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.