Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #85115: remove disk locks per vm #85830

Conversation

@aramase
Copy link
Member

aramase commented Dec 3, 2019

Cherry pick of #85115 on release-1.15.

#85115: remove disk locks per vm

For details on the cherry pick process, see the cherry pick requests page.

maintain map with nodename and lock

move lock map to utils
@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 3, 2019

/kind bug
/priority important-soon
/sig cloud-provider
/area provider/azure

@aramase aramase force-pushed the aramase:automated-cherry-pick-of-#85115-upstream-release-1.15 branch 2 times, most recently from 164f435 to c253262 Dec 3, 2019
@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 3, 2019

/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk
/test pull-kubernetes-e2e-azure-disk-vmss

go.mod Outdated Show resolved Hide resolved
@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Dec 3, 2019

/lgtm
/approve

@hoegaarden

This comment has been minimized.

Copy link
Member

hoegaarden commented Dec 3, 2019

Can we roll back the go mod changes? AFAIK the CP would be good to go then. @aramase

@aramase aramase force-pushed the aramase:automated-cherry-pick-of-#85115-upstream-release-1.15 branch from c253262 to f9c6f8b Dec 3, 2019
@k8s-ci-robot k8s-ci-robot added approved and removed lgtm labels Dec 3, 2019
@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 3, 2019

@hoegaarden thanks! removed the go.mod change.

@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 3, 2019

/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk
/test pull-kubernetes-e2e-azure-disk-vmss

@andyzhangx I don't see the test results for these runs. Do they not run against release branches?

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Dec 4, 2019

/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk
/test pull-kubernetes-e2e-azure-disk-vmss

@andyzhangx I don't see the test results for these runs. Do they not run against release branches?

it looks so, @chewong could you take a look? thanks,

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Dec 4, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@chewong

This comment has been minimized.

Copy link
Member

chewong commented Dec 4, 2019

/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk
/test pull-kubernetes-e2e-azure-disk-vmss

@andyzhangx I don't see the test results for these runs. Do they not run against release branches?

it looks so, @chewong could you take a look? thanks,

Looks like all three tests only run against PR merging to master branch - https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/azure/sig-azure-config.yaml#L6-L7. I will open a PR for running these tests on release branch.

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Dec 4, 2019

/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk
/test pull-kubernetes-e2e-azure-disk-vmss

Copy link
Member

andyzhangx left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 4, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6be7495 into kubernetes:release-1.15 Dec 5, 2019
14 of 15 checks passed
14 of 15 checks passed
tide Not mergeable. Should not have do-not-merge/cherry-pick-not-approved label.
Details
cla/linuxfoundation aramase authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-azure-disk Job succeeded.
Details
pull-kubernetes-e2e-azure-disk-vmss Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@aramase aramase deleted the aramase:automated-cherry-pick-of-#85115-upstream-release-1.15 branch Dec 5, 2019
@hoegaarden

This comment has been minimized.

Copy link
Member

hoegaarden commented Dec 5, 2019

There seems to be an issue with providerless: #85941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.