Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #85115: remove disk locks per vm #85832

Conversation

@aramase
Copy link
Member

aramase commented Dec 3, 2019

Cherry pick of #85115 on release-1.14.

#85115: remove disk locks per vm

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Dec 3, 2019
@k8s-ci-robot k8s-ci-robot requested review from andyzhangx and mikedanese Dec 3, 2019
@aramase aramase force-pushed the aramase:automated-cherry-pick-of-#85115-upstream-release-1.14 branch from a01c162 to 0d5e66d Dec 3, 2019
@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 3, 2019

/kind bug
/priority important-soon
/sig cloud-provider
/area provider/azure

@aramase aramase force-pushed the aramase:automated-cherry-pick-of-#85115-upstream-release-1.14 branch 2 times, most recently from f2f0075 to 7965f67 Dec 3, 2019
@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 3, 2019

/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk
/test pull-kubernetes-e2e-azure-disk-vmss

@aramase aramase force-pushed the aramase:automated-cherry-pick-of-#85115-upstream-release-1.14 branch from 7965f67 to a7abc99 Dec 3, 2019
@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 3, 2019

/test pull-kubernetes-e2e-gce

@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 3, 2019

/retest

Copy link
Member

andyzhangx left a comment

/lgtm
/approve

@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 4, 2019

/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk
/test pull-kubernetes-e2e-azure-disk-vmss

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Dec 4, 2019

/test pull-kubernetes-e2e-azure-disk-vmss

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Dec 4, 2019

/retest

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Dec 4, 2019

pls fix the godeps issue @aramase
and it always failed at following case:

I1204 10:00:23.758] [azuredisk-csi-e2e] Dynamic Provisioning [single-az] 
I1204 10:00:23.758]   should create multiple PV objects, bind to PVCs and attach all to different pods on the same node
I1204 10:00:23.759]   /go/src/sigs.k8s.io/azuredisk-csi-driver/test/e2e/dynamic_provisioning.go:148
I1204 10:00:23.759] STEP: Creating a kubernetes client
I1204 10:00:23.759] Dec  4 10:00:23.749: INFO: >>> kubeConfig: /workspace/aks396744930/kubeconfig/kubeconfig.westus2.json
I1204 10:00:23.759] STEP: Building a namespace api object, basename azuredisk
I1204 10:00:23.906] STEP: Waiting for a default service account to be provisioned in namespace
I1204 10:00:23.955] STEP: setting up the StorageClass
I1204 10:00:23.957] STEP: creating a StorageClass 
I1204 10:00:24.007] STEP: setting up the PVC and PV
I1204 10:00:24.007] STEP: creating a PVC
I1204 10:00:24.063] STEP: waiting for PVC to be in phase "Bound"
I1204 10:00:24.064] Dec  4 10:00:24.063: INFO: Waiting up to 5m0s for PersistentVolumeClaims [pvc-7jhbr] to have phase Bound
I1204 10:00:24.114] Dec  4 10:00:24.114: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:26.166] Dec  4 10:00:26.165: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:28.216] Dec  4 10:00:28.216: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:30.267] Dec  4 10:00:30.266: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:32.318] Dec  4 10:00:32.317: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:34.369] Dec  4 10:00:34.368: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:36.421] Dec  4 10:00:36.420: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:38.471] Dec  4 10:00:38.471: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:40.523] Dec  4 10:00:40.522: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:42.575] Dec  4 10:00:42.575: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:44.626] Dec  4 10:00:44.626: INFO: PersistentVolumeClaim pvc-7jhbr found but phase is Pending instead of Bound.
I1204 10:00:46.677] Dec  4 10:00:46.677: INFO: PersistentVolumeClaim pvc-7jhbr found and phase=Bound (22.613850341s)
I1204 10:00:46.678] STEP: checking the PVC
I1204 10:00:46.727] STEP: validating provisioned PV
I1204 10:00:46.777] STEP: checking the PV
I1204 10:00:46.778] STEP: setting up the pod
I1204 10:00:46.778] STEP: deploying the pod
I1204 10:00:46.829] STEP: checking that the pod is running
I1204 10:05:46.982] Dec  4 10:05:46.980: INFO: Unexpected error occurred: timed out waiting for the condition
I1204 10:05:46.982] Dec  4 10:05:46.981: INFO: deleting Pod "azuredisk-9782"/"azuredisk-volume-tester-cl9vs"
I1204 10:05:47.040] Dec  4 10:05:47.039: INFO: Error getting logs for pod azuredisk-volume-tester-cl9vs: the server rejected our request for an unknown reason (get pods azuredisk-volume-tester-cl9vs)

cc @chewong

maintain map with nodename and lock

move lock map to utils

add unit tests
@aramase aramase force-pushed the aramase:automated-cherry-pick-of-#85115-upstream-release-1.14 branch from a7abc99 to 74aa59b Dec 5, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 5, 2019
@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 5, 2019

/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk
/test pull-kubernetes-e2e-azure-disk-vmss

@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 5, 2019

/retest

@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 5, 2019

/test pull-kubernetes-godeps

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 5, 2019

@aramase: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-azure-disk-vmss 74aa59b link /test pull-kubernetes-e2e-azure-disk-vmss

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aramase

This comment has been minimized.

Copy link
Member Author

aramase commented Dec 5, 2019

@andyzhangx looks like pull-kubernetes-e2e-azure-disk-vmss is just generally failing on the 1.14 release branch. I tried a dummy PR to check and it failed there too - #85936

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Dec 5, 2019

@andyzhangx looks like pull-kubernetes-e2e-azure-disk-vmss is just generally failing on the 1.14 release branch. I tried a dummy PR to check and it failed there too - #85936

then let's go ahead with this cherry-pick, meanwhile I think there is sth wrong with 1.14.x on vmss cluster with following test scenario:

should create multiple PV objects, bind to PVCs and attach all to different pods on the same node

@aramase could you do a check? Thanks.

Copy link
Member

andyzhangx left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 5, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3c40a36 into kubernetes:release-1.14 Dec 5, 2019
13 of 15 checks passed
13 of 15 checks passed
pull-kubernetes-e2e-azure-disk-vmss Job failed.
Details
tide Not mergeable. Should not have do-not-merge/cherry-pick-not-approved label.
Details
cla/linuxfoundation aramase authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-azure-disk Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@aramase aramase deleted the aramase:automated-cherry-pick-of-#85115-upstream-release-1.14 branch Dec 5, 2019
@hoegaarden

This comment has been minimized.

Copy link
Member

hoegaarden commented Dec 5, 2019

There seems to be an issue with providerless: #85941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.