Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor matchingPrecedence to tighten the range #85841
[APPROVALNOTIFIER] This PR is NOT APPROVED
The full list of commands accepted by this bot can be found here.
I am not a fan of restricting the range more than necessary. If we decide we want the max to be a power of 10 then I think it should be 10^9.
I am not a fan of restricting the range. It adds a detail to the API: in addition to saying "int32" the API also has to say "the max is really 10000".
I do not see the fact that the maximum allowed value equals the maximum