Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checks.go #85857

Merged
merged 1 commit into from Dec 8, 2019
Merged

Update checks.go #85857

merged 1 commit into from Dec 8, 2019

Conversation

@hnanni
Copy link
Contributor

hnanni commented Dec 3, 2019

match kubernetes/release#653 add

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This is meant to check the existence of the conntrack utility during kubeadm's preflight
Not having that utility installed, will cause warnings like those mentioned in: clearlinux/distribution#1538
The conntrack utility was added as dependency for kubelet in: kubernetes/release#653

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

During initialization phase (preflight), kubeadm now verifies the presence of the conntrack executable

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 3, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 3, 2019

Welcome @hnanni!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 3, 2019

Hi @hnanni. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Dec 3, 2019

hi, please sing the CLA as the bot explains above.

what is your justification for requiring conntrack in the kubeadm checks?
please add that in the PR description.

@RA489

This comment has been minimized.

Copy link
Contributor

RA489 commented Dec 4, 2019

/check-cla

@rosti

This comment has been minimized.

Copy link
Member

rosti commented Dec 5, 2019

what is your justification for requiring conntrack in the kubeadm checks?

Actually, that has long been a requirement for the kubelet so it can cleanup its connections properly. The kubelet packages even depend on conntrack (so it's installed indirectly). Therefore I am +1 on this.

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Dec 5, 2019

@hnanni
the PR can be merged once your CLA is resolved.
if you are having troubles with that try contacting the CNCF help desk.

@hnanni

This comment has been minimized.

Copy link
Contributor Author

hnanni commented Dec 5, 2019

I signed it

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Dec 5, 2019

/release-note-none

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Dec 5, 2019

/kind cleanup
/priority backlog
/ok-to-test
/approve

@rosti

This comment has been minimized.

Copy link
Member

rosti commented Dec 6, 2019

@hnanni @neolit123 actually we do need a release note. This is going to error out in kubeadm, while if it's missing in the kubelet is going to cause mostly warnings and some leaks.

@hnanni can you add a release note to the Does this PR introduce a user-facing change?: section of your PR description? Something on the lines of this should do:

kubeadm now verifies the presence of the conntrack executable

/approve
/lgtm
/hold
for the release note.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hnanni, neolit123, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hnanni

This comment has been minimized.

Copy link
Contributor Author

hnanni commented Dec 6, 2019

Updated description.

@rosti

This comment has been minimized.

Copy link
Member

rosti commented Dec 6, 2019

Thanks for the update @hnanni !
However, the message needs to be in the release note quote for it to be picked up by the release automation tooling.

@hnanni

This comment has been minimized.

Copy link
Contributor Author

hnanni commented Dec 6, 2019

@rosti Sorry for the extra work.
I just learn about that markup. Ive edited the description again

@rosti

This comment has been minimized.

Copy link
Member

rosti commented Dec 8, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 2fbe432 into kubernetes:master Dec 8, 2019
14 of 15 checks passed
14 of 15 checks passed
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation hnanni authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 8, 2019
@hnanni hnanni deleted the hnanni:patch-1 branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.