Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to re-enable serving deprecated APIs #85903

Merged
merged 8 commits into from Dec 14, 2019

Conversation

@liggitt
Copy link
Member

liggitt commented Dec 4, 2019

What type of PR is this?
/kind api-change
/kind cleanup

What this PR does / why we need it:
Removes ability to re-enable serving deprecated extensions/v1beta1, apps/v1beta1, and apps/v1beta2 types

Which issue(s) this PR fixes:
xref #43214

Does this PR introduce a user-facing change?:

kube-apiserver no longer serves the following deprecated APIs:
* All resources under `apps/v1beta1` and `apps/v1beta2` - use `apps/v1` instead
* `daemonsets`, `deployments`, `replicasets` resources under `extensions/v1beta1` - use `apps/v1` instead
* `networkpolicies` resources under `extensions/v1beta1` - use `networking.k8s.io/v1` instead
* `podsecuritypolicies` resources under `extensions/v1beta1` - use `policy/v1beta1` instead

/cc @smarterclayton

@k8s-ci-robot k8s-ci-robot requested a review from smarterclayton Dec 4, 2019
@liggitt liggitt force-pushed the liggitt:disable-deprecated-apis branch from 443fe3f to 1ed4db8 Dec 4, 2019
@liggitt liggitt changed the title WIP - Disable deprecated apis WIP - Remove ability to re-enable serving deprecated APIs Dec 4, 2019
@liggitt liggitt force-pushed the liggitt:disable-deprecated-apis branch from 1ed4db8 to 779a067 Dec 4, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL and removed size/XL labels Dec 4, 2019
@liggitt liggitt force-pushed the liggitt:disable-deprecated-apis branch from 1914f49 to 591749d Dec 4, 2019
@liggitt liggitt changed the title WIP - Remove ability to re-enable serving deprecated APIs Remove ability to re-enable serving deprecated APIs Dec 4, 2019
@liggitt liggitt force-pushed the liggitt:disable-deprecated-apis branch from 591749d to 2bc22a9 Dec 4, 2019
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 4, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Dec 4, 2019

/retest

@soltysh soltysh mentioned this pull request Dec 4, 2019
32 of 41 tasks complete
@liggitt liggitt added this to the v1.18 milestone Dec 4, 2019
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Dec 5, 2019

/retest

@fedebongio

This comment has been minimized.

Copy link
Contributor

fedebongio commented Dec 5, 2019

/cc @lavalamp

@k8s-ci-robot k8s-ci-robot requested a review from lavalamp Dec 5, 2019
@liggitt liggitt force-pushed the liggitt:disable-deprecated-apis branch from 1801ab3 to 9b45285 Dec 10, 2019
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Dec 10, 2019

/retest

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Dec 13, 2019

looks ok to me, rebase and I'll tag. double checked the messages to consumers in previous changelogs to make sure we were consistent

@liggitt liggitt force-pushed the liggitt:disable-deprecated-apis branch from 9b45285 to 5c63715 Dec 13, 2019
@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Dec 13, 2019

rebased and updated release note

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 13, 2019

@liggitt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e-containerd 5c63715 link /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-e2e-gci-gce-autoscaling 5c63715 link /test pull-kubernetes-e2e-gci-gce-autoscaling
pull-kubernetes-e2e-gce-device-plugin-gpu 5c63715 link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Dec 13, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6a919f2 into kubernetes:master Dec 14, 2019
17 checks passed
17 checks passed
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Skipped
pull-kubernetes-e2e-gci-gce-autoscaling Skipped
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Skipped
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@liggitt liggitt deleted the liggitt:disable-deprecated-apis branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.