Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons: elasticsearch supports automatically setting the advertise address #85944

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@SataQiu
Copy link
Member

SataQiu commented Dec 5, 2019

What type of PR is this?
/kind bug
/kind feature

What this PR does / why we need it:
Elasticsearch supports automatically setting the advertise address.

Now, we set network.host to 0.0.0.0 by default. This works fine in IPv4 environment.
But in an IPv6 environment, member discovery will not work properly.
I tried to set network.host to "::1" in IPv6 environment, but it doesn't work.
The best way is to set network.host as the pod's real IP, either in an IPv4 or IPv6 environment.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

elasticsearch supports automatically setting the advertise address

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@SataQiu

This comment has been minimized.

Copy link
Member Author

SataQiu commented Dec 10, 2019

@coffeepac

This comment has been minimized.

Copy link
Member

coffeepac commented Dec 10, 2019

/approve

larger change though, going to need a little more time to test it manually.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SataQiu

This comment has been minimized.

Copy link
Member Author

SataQiu commented Dec 11, 2019

/test pull-kubernetes-e2e-gce

@SataQiu

This comment has been minimized.

Copy link
Member Author

SataQiu commented Dec 11, 2019

/approve

larger change though, going to need a little more time to test it manually.

I've tested this change and it works in both IPv4 and IPv6 environments, but I think it would be nice to have more comprehensive testing. @coffeepac

@SataQiu SataQiu force-pushed the SataQiu:fix-es-20191205 branch from 7dccfa7 to 09032be Dec 14, 2019
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Dec 14, 2019
@SataQiu

This comment has been minimized.

Copy link
Member Author

SataQiu commented Dec 14, 2019

Thanks @coffeepac
We should also push quay.io/fluentd_elasticsearch/elasticsearch:v7.4.2 into the image registry.

@SataQiu

This comment has been minimized.

Copy link
Member Author

SataQiu commented Dec 14, 2019

/test pull-kubernetes-e2e-gce

@SataQiu

This comment has been minimized.

Copy link
Member Author

SataQiu commented Dec 27, 2019

kindly ping @coffeepac
Can we move this forward?

@coffeepac

This comment has been minimized.

Copy link
Member

coffeepac commented Jan 8, 2020

@SataQiu many apologies, got eaten by the holidays. this is fine.

/lgtm

@coffeepac

This comment has been minimized.

Copy link
Member

coffeepac commented Jan 8, 2020

v7.4.2 image pushed to quay

@k8s-ci-robot k8s-ci-robot merged commit a233e01 into kubernetes:master Jan 8, 2020
16 checks passed
16 checks passed
cla/linuxfoundation SataQiu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.