Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring EndpointSlices are not used for Windows kube-proxy implementations #86016

Merged

Conversation

@robscott
Copy link
Member

robscott commented Dec 6, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
This ensures that EndpointSlices will not be used by Windows implementations of kube-proxy since they do not currently support EndpointSlices.

Which issue(s) this PR fixes:
Fixes #85352

Does this PR introduce a user-facing change?:

Fixes kube-proxy when EndpointSlice feature gate is enabled on Windows.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig network
/priority important-soon
/cc @freehan @JocelynBerrendonner

…ations
@k8s-ci-robot k8s-ci-robot requested a review from freehan Dec 6, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 6, 2019

@robscott: GitHub didn't allow me to request PR reviews from the following users: JocelynBerrendonner.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:
This ensures that EndpointSlices will not be used by Windows implementations of kube-proxy since they do not currently support EndpointSlices.

Which issue(s) this PR fixes:
Fixes #85352

Does this PR introduce a user-facing change?:

Fixes kube-proxy when EndpointSlice feature gate is enabled on Windows.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig network
/priority important-soon
/cc @freehan @JocelynBerrendonner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott

This comment has been minimized.

Copy link
Member Author

robscott commented Dec 7, 2019

/test pull-kubernetes-e2e-windows-gce

Copy link

JocelynBerrendonner left a comment

LGTM

Thanks for making this change!

@robscott

This comment has been minimized.

Copy link
Member Author

robscott commented Dec 7, 2019

/retest

@k8s-ci-robot k8s-ci-robot added size/M and removed size/XS labels Dec 9, 2019
@robscott

This comment has been minimized.

Copy link
Member Author

robscott commented Dec 9, 2019

/test pull-kubernetes-e2e-windows-gce

Going to hold this until I revert the change to enable EndpointSlices by default.
/hold

@robscott

This comment has been minimized.

Copy link
Member Author

robscott commented Dec 9, 2019

/test pull-kubernetes-e2e-gce

@robscott robscott force-pushed the robscott:endpointslice-windows-proxy branch from df6dfa6 to dfa04bf Dec 9, 2019
@k8s-ci-robot k8s-ci-robot added size/XS and removed size/M labels Dec 9, 2019
@robscott

This comment has been minimized.

Copy link
Member Author

robscott commented Dec 9, 2019

/retest

@robscott

This comment has been minimized.

Copy link
Member Author

robscott commented Dec 9, 2019

@freehan I think this should be good to go now. I temporarily enabled EndpointSlices by default on this PR for the sake of running Windows tests against it, and they seemed to pass as much as they usually do (not fully but mostly). The failures that existed did not seem related to networking in any way, and the kube-proxy logs looked reasonable to me. https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/86016/pull-kubernetes-e2e-windows-gce/1204123396347006976/artifacts/e2e-b2702382aa-95646-windows-node-group-0cnw/kube-proxy.log

@robscott

This comment has been minimized.

Copy link
Member Author

robscott commented Dec 16, 2019

/hold cancel

@freehan

This comment has been minimized.

Copy link
Member

freehan commented Dec 16, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 16, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Dec 17, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 078344c into kubernetes:master Dec 17, 2019
15 of 16 checks passed
15 of 16 checks passed
pull-kubernetes-e2e-windows-gce Job triggered.
Details
cla/linuxfoundation robscott authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 17, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 17, 2019

@robscott: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-windows-gce dfa04bf link /test pull-kubernetes-e2e-windows-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.