Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensuring EndpointSlices are not used for Windows kube-proxy implementations #86016
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
@robscott: GitHub didn't allow me to request PR reviews from the following users: JocelynBerrendonner.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@freehan I think this should be good to go now. I temporarily enabled EndpointSlices by default on this PR for the sake of running Windows tests against it, and they seemed to pass as much as they usually do (not fully but mostly). The failures that existed did not seem related to networking in any way, and the kube-proxy logs looked reasonable to me. https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/86016/pull-kubernetes-e2e-windows-gce/1204123396347006976/artifacts/e2e-b2702382aa-95646-windows-node-group-0cnw/kube-proxy.log
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
1 similar comment
@robscott: The following test failed, say