Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Burst limit for discovery client #86168

Merged
merged 1 commit into from Dec 11, 2019

Conversation

@liggitt
Copy link
Member

@liggitt liggitt commented Dec 11, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Increases default burst value for discovery client.

Which issue(s) this PR fixes:
Fixes #86149

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Resolves performance regression in `kubectl get all` and in client-go discovery clients constructed using `NewDiscoveryClientForConfig` or `NewDiscoveryClientForConfigOrDie`.

/cc @smarterclayton

serverResources, err := client.ServerResources()
if err != nil {
t.Errorf("unexpected error: %v", err)
}
end := time.Now()
if d := end.Sub(start); d > time.Second {
Copy link
Member Author

@liggitt liggitt Dec 11, 2019

This took ~2 seconds before the fix, and 2ms after.

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Dec 11, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Dec 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [liggitt,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt force-pushed the discovery-burst branch from 0451e6f to 711dc0b Dec 11, 2019
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Dec 11, 2019

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 11, 2019
@liggitt
Copy link
Member Author

@liggitt liggitt commented Dec 11, 2019

fixed spelling error, retagged

@liggitt liggitt added the lgtm label Dec 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0d58709 into kubernetes:master Dec 11, 2019
14 of 15 checks passed
14 of 15 checks passed
@k8s-ci-robot
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
@thelinuxfoundation
cla/linuxfoundation liggitt authorized
Details
@k8s-ci-robot
pull-kubernetes-bazel-build Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-bazel-test Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-dependencies Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-e2e-gce Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-e2e-kind Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-integration Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-node-e2e Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-typecheck Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 11, 2019
@liggitt liggitt deleted the discovery-burst branch Dec 12, 2019
k8s-ci-robot added a commit that referenced this issue Dec 15, 2019
…8-upstream-release-1.17

[1.17.1] Automated cherry pick of #86168: Increase Burst limit for discovery client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment