Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the status of static Pods #86189

Conversation

@tedyu
Copy link
Contributor

tedyu commented Dec 12, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
This refines the change introduced by #77661.
This PR sync's status for static pods.

Which issue(s) this PR fixes:
Fixes #84931

Fixed a regression where the kubelet would fail to update the ready status of pods.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Dec 12, 2019

/assign @dchen1107

@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Dec 14, 2019

/priority important-soon

@sftim

This comment has been minimized.

Copy link
Contributor

sftim commented Dec 19, 2019

/remove-priority backlog

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 7, 2020

Looks like this job was recently added and hasn't yet run against this PR:
/test pull-kubernetes-e2e-gce-100-performance

@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 8, 2020

@dchen1107
Can you approve this to meet the deadline ?

@derekwaynecarr

This comment has been minimized.

Copy link
Member

derekwaynecarr commented Jan 10, 2020

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d224476 into kubernetes:release-1.17 Jan 11, 2020
12 of 13 checks passed
12 of 13 checks passed
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation yutedz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.