kubeadm: add basic validation around kubelet.conf parsing #86216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user has modified the kubelet.conf post TLS bootstrap to become invalid, the function getNodeNameFromKubeletConfig() can panic. This was observed to trigger in "kubeadm reset" use cases. Add basic validation and unit tests around parsing the kubelet.conf with the aforementioned function.
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
the
priority/important-longterm
k8s-ci-robot
added
size/M
neolit123
commented
Dec 12, 2019
| apiEndpoints: | ||
| ` + nodeName + `: | ||
| apiEndpoints: | ||
| ` + nodeName + `: |
There was a problem hiding this comment.
these are some whitespace auto-cleanups by my editor.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If the user has modified the kubelet.conf post TLS bootstrap
to become invalid, the function getNodeNameFromKubeletConfig() can
panic. This was observed to trigger in "kubeadm reset" use cases.
Add basic validation and unit tests around parsing the kubelet.conf
with the aforementioned function.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
reported here:
https://kubernetes.slack.com/archives/C2P1JHS2E/p1576160868007800
i don't think we should backport because it's an edge-case.
but we definitely had this issue in a number of places in kubeadm already.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/priority important-longterm
/assign @fabriziopandini @rosti
/kind bug