Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubeadm]: Bump CoreDNS version to 1.6.7 #86260

Merged
merged 2 commits into from Feb 25, 2020

Conversation

@rajansandeep
Copy link
Member

rajansandeep commented Dec 13, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

Bumps CoreDNS version to 1.6.7
Also updates the migration library to 1.0.6 which supports coredns v1.6.7

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Kubeadm now includes CoreDNS version 1.6.7

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Dec 13, 2019

/lgtm
/approve

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Dec 13, 2019

See testing-ops for the SIG node e2e test failure, not specific to this PR

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Dec 14, 2019

thanks
/priority important-longterm
/lgtm
/approve

/retest

@gjtempleton

This comment has been minimized.

Copy link
Member

gjtempleton commented Jan 31, 2020

Worth noting that 1.6.6 includes a metrics regression in the cache plugin which we make use of: coredns/coredns#3577 (Users would see coredns_cache_misses_total disappearing, potentially causing alerts etc.)

As such I think this'll either need to come with a warning or jump to 1.6.7 instead as it's resolved there: coredns/coredns#3578

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Feb 19, 2020

@rajansandeep do we want this for 1.18?

@rajansandeep

This comment has been minimized.

Copy link
Member Author

rajansandeep commented Feb 19, 2020

@neolit123 yes, although I will be updating this PR to have CoreDNS 1.6.7

@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Feb 19, 2020

@rajansandeep ok, thanks.
FYI, code freeze is the 5th of March.

@rajansandeep rajansandeep force-pushed the rajansandeep:corednsto1.6.6-kubeadm branch from 197414b to cb12e8a Feb 24, 2020
@rajansandeep rajansandeep changed the title [kubeadm]: Bump CoreDNS version to 1.6.6 [kubeadm]: Bump CoreDNS version to 1.6.7 Feb 24, 2020
@neolit123

This comment has been minimized.

Copy link
Member

neolit123 commented Feb 24, 2020

/lgtm
/assign @liggitt

@rajansandeep should kube-up be bumped as well in a separate PR?

@rajansandeep

This comment has been minimized.

Copy link
Member Author

rajansandeep commented Feb 24, 2020

@rajansandeep should kube-up be bumped as well in a separate PR?

Yes, I'll be updating #86259 for kube-up

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 24, 2020

vendor changes lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt, neolit123, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Feb 24, 2020

/retest

1 similar comment
@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Feb 24, 2020

/retest

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Feb 24, 2020

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 25, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 95504c3 into kubernetes:master Feb 25, 2020
16 of 17 checks passed
16 of 17 checks passed
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
cla/linuxfoundation rajansandeep authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-e2e-kind-ipv6 Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.