Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set core_pattern to an absolute path. #86329

Merged
merged 1 commit into from Dec 18, 2019
Merged

Conversation

@mml
Copy link
Contributor

mml commented Dec 16, 2019

Change-Id: I71e848783c05dc75b2232e05dd2ed3aa9a983e23

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes the core_pattern value in GCI.

Which issue(s) this PR fixes:
Fixes #86328

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Changed core_pattern on COS nodes to be an absolute path.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Change-Id: I71e848783c05dc75b2232e05dd2ed3aa9a983e23
@mml

This comment has been minimized.

Copy link
Contributor Author

mml commented Dec 16, 2019

/assign @yguo0905

@mml

This comment has been minimized.

Copy link
Contributor Author

mml commented Dec 16, 2019

I tested this manually and verified the core file ends up in the namespace (container) root, not the root fs from the kernel's PoV.

@cheftako

This comment has been minimized.

Copy link
Member

cheftako commented Dec 17, 2019

/lgtm

Copy link
Contributor

mattjmcnaughton left a comment

/test pull-kubernetes-e2e-kind

Thanks for your pr :)

/assign @yguo0905

There's no harm to including a release note, but I'm not sure we need one for this diff. I think its a fairly internal change. So feel free to update the release note to NONE.

@@ -29,7 +29,7 @@ function setup-os-params {
# Reset core_pattern. On GCI, the default core_pattern pipes the core dumps to
# /sbin/crash_reporter which is more restrictive in saving crash dumps. So for
# now, set a generic core_pattern that users can work with.
echo "core.%e.%p.%t" > /proc/sys/kernel/core_pattern
echo "/core.%e.%p.%t" > /proc/sys/kernel/core_pattern

This comment has been minimized.

Copy link
@mattjmcnaughton

mattjmcnaughton Dec 17, 2019

Contributor

Could you please share more about why the issue is occurring?

If we do decide using an absolute path is the best way to address the given issue, I think it'd be helpful to update the comment to ensure that knowledge is accessible and displayed to the user.

This comment has been minimized.

Copy link
@cheftako

cheftako Dec 17, 2019

Member

Reference http://man7.org/linux/man-pages/man5/core.5.html
"Since Linux 3.6, if /proc/sys/fs/suid_dumpable is set to 2
("suidsafe"), the pattern must be either an absolute pathname
(starting with a leading '/' character) or a pipe, as defined below"

This comment has been minimized.

Copy link
@mattjmcnaughton

mattjmcnaughton Dec 18, 2019

Contributor

Today I learned :) Thank you!

@yguo0905

This comment has been minimized.

Copy link
Contributor

yguo0905 commented Dec 17, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mml, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a62b3a into kubernetes:master Dec 18, 2019
15 checks passed
15 checks passed
cla/linuxfoundation mml authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.