Skip to content

Set core_pattern to an absolute path. #86329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Set core_pattern to an absolute path. #86329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cluster/gce/gci/configure-helper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function setup-os-params {
# Reset core_pattern. On GCI, the default core_pattern pipes the core dumps to
# /sbin/crash_reporter which is more restrictive in saving crash dumps. So for
# now, set a generic core_pattern that users can work with.
echo "core.%e.%p.%t" > /proc/sys/kernel/core_pattern
echo "/core.%e.%p.%t" > /proc/sys/kernel/core_pattern
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please share more about why the issue is occurring?

If we do decide using an absolute path is the best way to address the given issue, I think it'd be helpful to update the comment to ensure that knowledge is accessible and displayed to the user.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference http://man7.org/linux/man-pages/man5/core.5.html
"Since Linux 3.6, if /proc/sys/fs/suid_dumpable is set to 2
("suidsafe"), the pattern must be either an absolute pathname
(starting with a leading '/' character) or a pipe, as defined below"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today I learned :) Thank you!

}

# secure_random generates a secure random string of bytes. This function accepts
Expand Down