Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pull request #85879 "hollow-node use remote CRI" #86425

Merged
merged 1 commit into from Dec 19, 2019

Conversation

@jkaniuk
Copy link
Contributor

jkaniuk commented Dec 19, 2019

Kubemark tests started failing after merge of #86423:
https://k8s-testgrid.appspot.com/sig-scalability-kubemark#kubemark-100

What type of PR is this?
/kind bug

Which issue(s) this PR fixes:
Fixes #86423

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

hollow-node do not use remote CRI anymore

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig scalability
/cc @mm4tt @wojtek-t @gongguan @dashpole

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Dec 19, 2019

@gongguan - FYI

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkaniuk, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gongguan

This comment has been minimized.

Copy link
Contributor

gongguan commented Dec 19, 2019

/priority critical-urgent

@gongguan

This comment has been minimized.

Copy link
Contributor

gongguan commented Dec 19, 2019

/retest

1 similar comment
@gongguan

This comment has been minimized.

Copy link
Contributor

gongguan commented Dec 19, 2019

/retest

@gongguan

This comment has been minimized.

Copy link
Contributor

gongguan commented Dec 19, 2019

thanks jkaniuk, sorry for making it.

@gongguan

This comment has been minimized.

Copy link
Contributor

gongguan commented Dec 19, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Dec 19, 2019

#86317 flake
/retest

@k8s-ci-robot k8s-ci-robot merged commit 9f841bf into kubernetes:master Dec 19, 2019
15 checks passed
15 checks passed
cla/linuxfoundation jkaniuk authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.