Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix azure cloud provider bug when lb specified in other resource group #86502

Merged
merged 2 commits into from Dec 22, 2019

Conversation

@levimm
Copy link
Contributor

levimm commented Dec 21, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:
Fix the resource not found bug in cloud provider azure when specifying LoadBalancer in another resource group.

Which issue(s) this PR fixes:

Fixes #85805

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix issue #85805 about resource not found in azure cloud provider when lb specified in other resource group.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 21, 2019

Hi @levimm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@levimm

This comment has been minimized.

Copy link
Contributor Author

levimm commented Dec 21, 2019

/assign
cc @feiskyer

Copy link
Member

feiskyer left a comment

/kind bug
/area provider/azure
/priority important-soon
/ok-to-test

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Dec 21, 2019

Please add a release note in Does this PR introduce a user-facing change part, as we need cherry pick this to older releases.

@levimm levimm force-pushed the levimm:fixAzureLB branch from 52bd1ed to 9e26f74 Dec 21, 2019
@levimm levimm force-pushed the levimm:fixAzureLB branch from 9e26f74 to e4c87c2 Dec 21, 2019
@levimm levimm requested a review from feiskyer Dec 21, 2019
@levimm

This comment has been minimized.

Copy link
Contributor Author

levimm commented Dec 21, 2019

/retest

@feiskyer

This comment has been minimized.

Copy link
Member

feiskyer commented Dec 21, 2019

Please run ./hack/update-gofmt.sh to fix verify failures

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Dec 22, 2019

/test pull-kubernetes-e2e-aks-engine-azure
/test pull-kubernetes-e2e-azure-disk
/test pull-kubernetes-e2e-azure-disk-vmss

@levimm

This comment has been minimized.

Copy link
Contributor Author

levimm commented Dec 22, 2019

/test pull-kubernetes-e2e-gce

1 similar comment
@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Dec 22, 2019

/test pull-kubernetes-e2e-gce

Copy link
Member

feiskyer left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 22, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, levimm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4f70231 into kubernetes:master Dec 22, 2019
18 checks passed
18 checks passed
cla/linuxfoundation levimm authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-azure-disk Job succeeded.
Details
pull-kubernetes-e2e-azure-disk-vmss Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.