Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore IPAllocator ipv4 range handling #86534

Merged
merged 2 commits into from Dec 23, 2019

Conversation

@liggitt
Copy link
Member

@liggitt liggitt commented Dec 23, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Reverts the IP allocator portions of #83422, adds unit test covering #86497 scenario

Which issue(s) this PR fixes:
Fixes #86497

Does this PR introduce a user-facing change?:

Fixes v1.17.0 regression in --service-cluster-ip-range handling with IPv4 ranges larger than 65536 IP addresses
@liggitt
Copy link
Member Author

@liggitt liggitt commented Dec 23, 2019

/sig network
/cc @yastij

@liggitt
Copy link
Member Author

@liggitt liggitt commented Dec 23, 2019

/priority critical-urgent
/milestone v1.17

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Dec 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

@liggitt liggitt commented Dec 23, 2019

/hold for network review

@neolit123
Copy link
Member

@neolit123 neolit123 commented Dec 23, 2019

LGTM, thanks.

as part of #83422:

https://github.com/kubernetes/kubernetes/pull/83422/files#diff-8901e0d89ec6745ac599b98964928090R388
https://github.com/kubernetes/kubernetes/pull/83422/files#diff-8901e0d89ec6745ac599b98964928090R400

are not very problematic as the clamped results only compare to the constant 10.
can be fixed in a separate PR in master and a backport is not needed.

i will log an issue in k/kubeadm for that.
EDIT: kubernetes/kubeadm#1985

@liggitt
Copy link
Member Author

@liggitt liggitt commented Dec 23, 2019

Yeah, I swept the other uses and they looked to be done only for validation against much smaller ranges

Copy link
Member

@yastij yastij left a comment

/lgtm

@liggitt
Copy link
Member Author

@liggitt liggitt commented Dec 23, 2019

/hold cancel

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Dec 23, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt
Copy link
Member Author

@liggitt liggitt commented Dec 23, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5e31799 into kubernetes:master Dec 23, 2019
14 of 15 checks passed
14 of 15 checks passed
@k8s-ci-robot
tide Not mergeable. Retesting: pull-kubernetes-kubemark-e2e-gce-big
Details
@thelinuxfoundation
cla/linuxfoundation liggitt authorized
Details
@k8s-ci-robot
pull-kubernetes-bazel-build Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-bazel-test Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-dependencies Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-e2e-gce Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-e2e-kind Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-integration Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-node-e2e Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-typecheck Job succeeded.
Details
@k8s-ci-robot
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot removed this from the v1.17 milestone Dec 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 23, 2019
k8s-ci-robot added a commit that referenced this issue Dec 25, 2019
…4-upstream-release-1.17

[v1.17.1] Automated cherry pick of #86534: Revert "remove ipallocator in favor of k/utils net
@liggitt liggitt deleted the ipallocator-range branch Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment