Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate scheduling_algorithm_predicate_evaluation_seconds and sched… #86584

Conversation

@xiaoanyunfei
Copy link
Member

xiaoanyunfei commented Dec 24, 2019

…uling_algorithm_priority_evaluation_seconds

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

  • scheduling_algorithm_predicate_evaluation_seconds, replaced by framework_extension_point_duration_seconds[extenstion_point="Filter"]
  • scheduling_algorithm_priority_evaluation_seconds, replaced by framework_extension_point_duration_seconds[extenstion_point="Score"]
    Which issue(s) this PR fixes:

Ref # #86391

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Marked scheduler's metrics scheduling_algorithm_predicate_evaluation_seconds and
scheduling_algorithm_priority_evaluation_seconds as deprecated. Those are replaced by framework_extension_point_duration_seconds[extenstion_point="Filter"] and framework_extension_point_duration_seconds[extenstion_point="Score"] respectively.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig scheduling
/assign @liu-cong

@xiaoanyunfei xiaoanyunfei force-pushed the xiaoanyunfei:cleanup/deprecate_scheduler_metrics branch from a4f3a14 to 9767696 Dec 24, 2019
@liu-cong

This comment has been minimized.

Copy link
Contributor

liu-cong commented Jan 2, 2020

/lgtm

@ahg-g , can you take a quick look?

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 2, 2020
@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Jan 2, 2020

Please update the section "Does this PR introduce a user-facing change?:" with:

"Marked scheduler's metrics scheduling_algorithm_predicate_evaluation_seconds and
scheduling_algorithm_priority_evaluation_seconds as deprecated. Those are replaced by framework_extension_point_duration_seconds[extenstion_point="Filter"] and framework_extension_point_duration_seconds[extenstion_point="Score"] respectively."

@xiaoanyunfei

This comment has been minimized.

Copy link
Member Author

xiaoanyunfei commented Jan 3, 2020

/test pull-kubernetes-e2e-gce

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Jan 3, 2020

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, xiaoanyunfei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaoanyunfei

This comment has been minimized.

Copy link
Member Author

xiaoanyunfei commented Jan 3, 2020

/test pull-kubernetes-e2e-gce

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 3, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 3, 2020

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 180e1c9 into kubernetes:master Jan 3, 2020
14 of 15 checks passed
14 of 15 checks passed
tide Not mergeable. Retesting: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation xiaoanyunfei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 3, 2020
@xiaoanyunfei xiaoanyunfei deleted the xiaoanyunfei:cleanup/deprecate_scheduler_metrics branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.