Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate scheduling_duration_seconds Summary metric #86586

Conversation

@xiaoanyunfei
Copy link
Member

xiaoanyunfei commented Dec 24, 2019

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Deprecate scheduling_duration_seconds Summary metric

Which issue(s) this PR fixes:

Ref # #86391

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Marked scheduler's scheduling_duration_seconds Summary metric as deprecated

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig scheduling
/assign @liu-cong

@liu-cong

This comment has been minimized.

Copy link
Contributor

liu-cong commented Jan 2, 2020

/lgtm

@ahg-g , can you take a quick look?

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 2, 2020
@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Jan 2, 2020

Please update "Does this PR introduce a user-facing change?:" with "Marked scheduler's scheduling_duration_seconds Summary metric as deprecated"

@xiaoanyunfei

This comment has been minimized.

Copy link
Member Author

xiaoanyunfei commented Jan 3, 2020

Please update "Does this PR introduce a user-facing change?:" with "Marked scheduler's scheduling_duration_seconds Summary metric as deprecated"

done

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Jan 3, 2020

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, xiaoanyunfei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fdfcb00 into kubernetes:master Jan 3, 2020
15 checks passed
15 checks passed
cla/linuxfoundation xiaoanyunfei authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.